Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 568293b8 authored by David Keitel's avatar David Keitel Committed by Kyle Yan
Browse files

checkpatch: warn on subject line not followed by blank line 



Fixed case when no warning generated for long subject line that is
wrapped to more than one line, and all lines are less than line limit.

New warning message added:
"non-blank line after summary line"
Now there are two warnings possible for the subject line, the original
line over limit and the new one. Depending on the error(s) any
combination of the two warnings are possible.

Commit text requirements now:
1) Must be less than 75 characters
2) Must be followed by blank line.

Signed-off-by: default avatarDavid Keitel <dkeitel@codeaurora.org>
parent 585ada4f

scripts/checkpatch.pl

+17 −1
Original line number Diff line number Diff line
@@ -14,6 +14,7 @@ use Term::ANSIColor qw(:constants); 
use constant BEFORE_SHORTTEXT => 0;

use constant IN_SHORTTEXT => 1;

use constant AFTER_SHORTTEXT => 2;

use constant CHECK_NEXT_SHORTTEXT => 3;

use constant SHORTTEXT_LIMIT => 75;



my $P = $0;
@@ -2005,6 +2006,8 @@ sub process { 
	my $prevrawline="";

	my $stashline="";

	my $stashrawline="";

	my $subjectline="";

	my $sublinenr="";



	my $length;

	my $indent;
@@ -2266,8 +2269,21 @@ sub process { 
					     SHORTTEXT_LIMIT .

					     " characters\n" . $herecurr);

				}

			} elsif ($line=~/^Subject: \[[^\]]*\] (.*)/) {

			} elsif ($shorttext == CHECK_NEXT_SHORTTEXT) {

				$shorttext = IN_SHORTTEXT;

# Check for Subject line followed by a blank line.

				if (length($line) != 0) {

					WARN("NONBLANK_AFTER_SUMMARY",

					     "non-blank line after summary " .

					     "line\n" . $sublinenr . $here .

					     "\n" . $subjectline . "\n" .

					     $line . "\n");

				}

			} elsif ($line=~/^Subject: \[[^\]]*\] (.*)/) {

				$shorttext = CHECK_NEXT_SHORTTEXT;

				$subjectline = $line;

				$sublinenr = "#$linenr & ";

# Check for Subject line less than line limit

				if (length($1) > SHORTTEXT_LIMIT) {

					WARN("LONG_SUMMARY_LINE",

					     "summary line over " .