Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 53e3b6e2 authored by Bob Copeland's avatar Bob Copeland Committed by John W. Linville
Browse files

ath5k: remove debug_dump_skb() functions 



Now that rx and tx dumps go through the tracing infrastructure,
we no longer need to keep these routines around.

Signed-off-by: default avatarBob Copeland <me@bobcopeland.com>
Acked-by: default avatarBruno Randolf <br1@einfach.org>
Acked-by: default avatarNick Kossifidis <mickflemm@gmail.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 0e472252

drivers/net/wireless/ath/ath5k/debug.c

+0 −20
Original line number Original line Diff line number Diff line
@@ -308,8 +308,6 @@ static const struct { 
	{ ATH5K_DEBUG_CALIBRATE, "calib",	"periodic calibration" },

	{ ATH5K_DEBUG_CALIBRATE, "calib",	"periodic calibration" },

	{ ATH5K_DEBUG_TXPOWER,	"txpower",	"transmit power setting" },

	{ ATH5K_DEBUG_TXPOWER,	"txpower",	"transmit power setting" },

	{ ATH5K_DEBUG_LED,	"led",		"LED management" },

	{ ATH5K_DEBUG_LED,	"led",		"LED management" },

	{ ATH5K_DEBUG_DUMP_RX,	"dumprx",	"print received skb content" },

	{ ATH5K_DEBUG_DUMP_TX,	"dumptx",	"print transmit skb content" },

	{ ATH5K_DEBUG_DUMPBANDS, "dumpbands",	"dump bands" },

	{ ATH5K_DEBUG_DUMPBANDS, "dumpbands",	"dump bands" },

	{ ATH5K_DEBUG_DMA,	"dma",		"dma start/stop" },

	{ ATH5K_DEBUG_DMA,	"dma",		"dma start/stop" },

	{ ATH5K_DEBUG_ANI,	"ani",		"adaptive noise immunity" },

	{ ATH5K_DEBUG_ANI,	"ani",		"adaptive noise immunity" },
@@ -1035,24 +1033,6 @@ ath5k_debug_printrxbuffs(struct ath5k_softc *sc, struct ath5k_hw *ah) 
	spin_unlock_bh(&sc->rxbuflock);

	spin_unlock_bh(&sc->rxbuflock);

}

}





void

ath5k_debug_dump_skb(struct ath5k_softc *sc,

			struct sk_buff *skb, const char *prefix, int tx)

{

	char buf[16];



	if (likely(!((tx && (sc->debug.level & ATH5K_DEBUG_DUMP_TX)) ||

		     (!tx && (sc->debug.level & ATH5K_DEBUG_DUMP_RX)))))

		return;



	snprintf(buf, sizeof(buf), "%s %s", wiphy_name(sc->hw->wiphy), prefix);



	print_hex_dump_bytes(buf, DUMP_PREFIX_NONE, skb->data,

		min(200U, skb->len));



	printk(KERN_DEBUG "\n");

}



void

void

ath5k_debug_printtxbuf(struct ath5k_softc *sc, struct ath5k_buf *bf)

ath5k_debug_printtxbuf(struct ath5k_softc *sc, struct ath5k_buf *bf)

{

{

drivers/net/wireless/ath/ath5k/debug.h

+0 −10
Original line number Original line Diff line number Diff line
@@ -116,8 +116,6 @@ enum ath5k_debug_level { 
	ATH5K_DEBUG_CALIBRATE	= 0x00000020,

	ATH5K_DEBUG_CALIBRATE	= 0x00000020,

	ATH5K_DEBUG_TXPOWER	= 0x00000040,

	ATH5K_DEBUG_TXPOWER	= 0x00000040,

	ATH5K_DEBUG_LED		= 0x00000080,

	ATH5K_DEBUG_LED		= 0x00000080,

	ATH5K_DEBUG_DUMP_RX	= 0x00000100,

	ATH5K_DEBUG_DUMP_TX	= 0x00000200,

	ATH5K_DEBUG_DUMPBANDS	= 0x00000400,

	ATH5K_DEBUG_DUMPBANDS	= 0x00000400,

	ATH5K_DEBUG_DMA		= 0x00000800,

	ATH5K_DEBUG_DMA		= 0x00000800,

	ATH5K_DEBUG_ANI		= 0x00002000,

	ATH5K_DEBUG_ANI		= 0x00002000,
@@ -151,10 +149,6 @@ ath5k_debug_printrxbuffs(struct ath5k_softc *sc, struct ath5k_hw *ah); 
void

void

ath5k_debug_dump_bands(struct ath5k_softc *sc);

ath5k_debug_dump_bands(struct ath5k_softc *sc);





void

ath5k_debug_dump_skb(struct ath5k_softc *sc,

			struct sk_buff *skb, const char *prefix, int tx);



void

void

ath5k_debug_printtxbuf(struct ath5k_softc *sc, struct ath5k_buf *bf);

ath5k_debug_printtxbuf(struct ath5k_softc *sc, struct ath5k_buf *bf);
@@ -181,10 +175,6 @@ ath5k_debug_printrxbuffs(struct ath5k_softc *sc, struct ath5k_hw *ah) {} 
static inline void

static inline void

ath5k_debug_dump_bands(struct ath5k_softc *sc) {}

ath5k_debug_dump_bands(struct ath5k_softc *sc) {}





static inline void

ath5k_debug_dump_skb(struct ath5k_softc *sc,

			struct sk_buff *skb, const char *prefix, int tx) {}



static inline void

static inline void

ath5k_debug_printtxbuf(struct ath5k_softc *sc, struct ath5k_buf *bf) {}

ath5k_debug_printtxbuf(struct ath5k_softc *sc, struct ath5k_buf *bf) {}