Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5394d6e6 authored by Morten Rasmussen's avatar Morten Rasmussen Committed by Gerrit - the friendly Code Review server
Browse files

ANDROID: sched/fair: Energy-aware wake-up task placement 



When the systems is not overutilized, place waking tasks on the most
energy efficient cpu. Previous attempts reduced the search space by
matching task utilization to cpu capacity before consulting the energy
model as this is an expensive operation. The search heuristics didn't
work very well and lacking any better alternatives this patch takes the
brute-force route and tries all potential targets.

This approach doesn't scale, but it might be sufficient for many
embedded applications while work is continuing on a heuristic that can
minimize the necessary computations. The heuristic must be derrived from
the platform energy model rather than make additional assumptions, such
lower capacity implies better energy efficiency. PeterZ mentioned in the
past that we might be able to derrive some simpler deciding functions
using mathematical (modal?) analysis.

Signed-off-by: default avatarMorten Rasmussen <morten.rasmussen@arm.com>
Change-Id: I424e72ab15529e45e8788d109823ae0f6de0d97f
Signed-off-by: default avatarChris Redpath <chris.redpath@arm.com>
Git-commit: 3308a3b6
Git-repo: https://android.googlesource.com/kernel/common/


Signed-off-by: default avatarSatya Durga Srinivasu Prabhala <satyap@codeaurora.org>
parent aa19c5c3

kernel/sched/fair.c

+57 −0
Original line number Diff line number Diff line
@@ -6219,6 +6219,60 @@ static bool cpu_overutilized(int cpu) 
	return (capacity_of(cpu) * 1024) < (cpu_util(cpu) * capacity_margin);

}



static int select_energy_cpu_brute(struct task_struct *p, int prev_cpu)

{

	int i;

	int min_diff = 0, energy_cpu = prev_cpu, spare_cpu = prev_cpu;

	unsigned long max_spare = 0;

	struct sched_domain *sd;



	rcu_read_lock();



	sd = rcu_dereference(per_cpu(sd_ea, prev_cpu));



	if (!sd)

		goto unlock;



	for_each_cpu_and(i, &p->cpus_allowed, sched_domain_span(sd)) {

		int diff;

		unsigned long spare;



		struct energy_env eenv = {

			.util_delta	= task_util(p),

			.src_cpu	= prev_cpu,

			.dst_cpu	= i,

		};



		spare = capacity_spare_wake(i, p);



		if (i == prev_cpu)

			continue;



		if (spare > max_spare) {

			max_spare = spare;

			spare_cpu = i;

		}



		if (spare * 1024 < capacity_margin * task_util(p))

			continue;



		diff = energy_diff(&eenv);



		if (diff < min_diff) {

			min_diff = diff;

			energy_cpu = i;

		}

	}



unlock:

	rcu_read_unlock();



	if (energy_cpu == prev_cpu && !cpu_overutilized(prev_cpu))

		return prev_cpu;



	return energy_cpu != prev_cpu ? energy_cpu : spare_cpu;

}



/*

 * select_task_rq_fair: Select target runqueue for the waking task in domains

 * that have the 'sd_flag' flag set. In practice, this is SD_BALANCE_WAKE,
@@ -6246,6 +6300,9 @@ select_task_rq_fair(struct task_struct *p, int prev_cpu, int sd_flag, int wake_f 
			      && cpumask_test_cpu(cpu, &p->cpus_allowed);

	}



	if (energy_aware() && !(cpu_rq(prev_cpu)->rd->overutilized))

		return select_energy_cpu_brute(p, prev_cpu);



	rcu_read_lock();

	for_each_domain(cpu, tmp) {

		if (!(tmp->flags & SD_LOAD_BALANCE))