Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 534249d6 authored by Varka Bhadram's avatar Varka Bhadram Committed by David S. Miller
Browse files

ethernet: apm: xgene: remove unnecessary check 



devm_ioremap_resource checks platform_get_resource() return value.
We can remove the duplicate check here.

Signed-off-by: default avatarVarka Bhadram <varkab@cdac.in>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5e9b4dce

drivers/net/ethernet/apm/xgene/xgene_enet_main.c

+0 −12
Original line number Diff line number Diff line
@@ -761,10 +761,6 @@ static int xgene_enet_get_resources(struct xgene_enet_pdata *pdata) 
	ndev = pdata->ndev;



	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "enet_csr");

	if (!res) {

		dev_err(dev, "Resource enet_csr not defined\n");

		return -ENODEV;

	}

	pdata->base_addr = devm_ioremap_resource(dev, res);

	if (IS_ERR(pdata->base_addr)) {

		dev_err(dev, "Unable to retrieve ENET Port CSR region\n");
@@ -772,10 +768,6 @@ static int xgene_enet_get_resources(struct xgene_enet_pdata *pdata) 
	}



	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ring_csr");

	if (!res) {

		dev_err(dev, "Resource ring_csr not defined\n");

		return -ENODEV;

	}

	pdata->ring_csr_addr = devm_ioremap_resource(dev, res);

	if (IS_ERR(pdata->ring_csr_addr)) {

		dev_err(dev, "Unable to retrieve ENET Ring CSR region\n");
@@ -783,10 +775,6 @@ static int xgene_enet_get_resources(struct xgene_enet_pdata *pdata) 
	}



	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ring_cmd");

	if (!res) {

		dev_err(dev, "Resource ring_cmd not defined\n");

		return -ENODEV;

	}

	pdata->ring_cmd_addr = devm_ioremap_resource(dev, res);

	if (IS_ERR(pdata->ring_cmd_addr)) {

		dev_err(dev, "Unable to retrieve ENET Ring command region\n");