Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 52eb92c6 authored by Imre Deak's avatar Imre Deak
Browse files

drm/i915/lvds: Remove magic from PLL programming 



This looks like a left-over from enabling work. The spec defines
CH7017_LVDS_PLL_FEEDBACK_DEFAULT_RESERVED as reserved set, so follow
this in the programming.

v2:
- Follow the spec to set CH7017_LVDS_PLL_FEEDBACK_DEFAULT_RESERVED.
  (Ville)

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: default avatarImre Deak <imre.deak@intel.com>
Reviewed-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1494408113-379-7-git-send-email-imre.deak@intel.com
parent a92d1a91

drivers/gpu/drm/i915/dvo_ch7017.c

+2 −2
Original line number Diff line number Diff line
@@ -280,10 +280,10 @@ static void ch7017_mode_set(struct intel_dvo_device *dvo, 
			(0 << CH7017_PHASE_DETECTOR_SHIFT);

	} else {

		outputs_enable = CH7017_LVDS_CHANNEL_A | CH7017_CHARGE_PUMP_HIGH;

		lvds_pll_feedback_div = CH7017_LVDS_PLL_FEEDBACK_DEFAULT_RESERVED |

		lvds_pll_feedback_div =

			CH7017_LVDS_PLL_FEEDBACK_DEFAULT_RESERVED |

			(2 << CH7017_LVDS_PLL_FEED_BACK_DIVIDER_SHIFT) |

			(3 << CH7017_LVDS_PLL_FEED_FORWARD_DIVIDER_SHIFT);

		lvds_pll_feedback_div = 35;

		lvds_control_2 = (3 << CH7017_LOOP_FILTER_SHIFT) |

			(0 << CH7017_PHASE_DETECTOR_SHIFT);

		if (1) { /* XXX: dual channel panel detection.  Assume yes for now. */