Commit 52b81611 authored Sep 05, 2017 by Xu YiPing Committed by Greg Kroah-Hartman Sep 18, 2017

binder: fix an ret value override



commit 372e3147 ("binder: guarantee txn complete / errors delivered
in-order") incorrectly defined a local ret value.  This ret value will
be invalid when out of the if block

Fixes: 372e3147 ("binder: refactor binder ref inc/dec for thread safety")
Signed-off-by: Xu YiPing <xuyiping@hislicon.com>
Signed-off-by: Todd Kjos <tkjos@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 1c363eae

drivers/android/binder.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -2326,7 +2326,6 @@ static int binder_translate_handle(struct flat_binder_object *fp,
		(u64)node->ptr);
		binder_node_unlock(node);
		} else {
		int ret;
		struct binder_ref_data dest_rdata;

		binder_node_unlock(node);