Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5264682a authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Mauro Carvalho Chehab
Browse files

[media] v4l: omap3isp: Don't check for missing get_fmt op on remote subdev 



The remote subdev of any video node in the OMAP3 ISP is an internal
subdev that is guaranteed to implement get_fmt. Don't check the return
value for -ENOIOCTLCMD, as this can't happen.
While at it, move non-critical code out of the mutex-protected section.

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: default avatarSakari Ailus <sakari.ailus@iki.fi>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 9323297d

drivers/media/platform/omap3isp/ispvideo.c

+2 −5
Original line number Diff line number Diff line
@@ -339,14 +339,11 @@ __isp_video_get_format(struct isp_video *video, struct v4l2_format *format) 
	if (subdev == NULL)

		return -EINVAL;



	mutex_lock(&video->mutex);



	fmt.pad = pad;

	fmt.which = V4L2_SUBDEV_FORMAT_ACTIVE;

	ret = v4l2_subdev_call(subdev, pad, get_fmt, NULL, &fmt);

	if (ret == -ENOIOCTLCMD)

		ret = -EINVAL;



	mutex_lock(&video->mutex);

	ret = v4l2_subdev_call(subdev, pad, get_fmt, NULL, &fmt);

	mutex_unlock(&video->mutex);



	if (ret)