Commit 519a2861 authored Dec 10, 2014 by Dan Carpenter Committed by Linus Torvalds Dec 10, 2014

ocfs2: fix an off-by-one BUG_ON() statement

The ->si_slots[] array is allocated in ocfs2_init_slot_info() it has
"->max_slots" number of elements so this test should be >= instead of >.

Static checker work.  Compile tested only.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Mark Fasheh <mfasheh@suse.com>
Cc: Joel Becker <jlbec@evilplan.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent f08736bd

fs/ocfs2/slot_map.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -306,7 +306,7 @@ int ocfs2_slot_to_node_num_locked(struct ocfs2_super *osb, int slot_num,
	assert_spin_locked(&osb->osb_lock);		assert_spin_locked(&osb->osb_lock);

	BUG_ON(slot_num < 0);		BUG_ON(slot_num < 0);
	BUG_ON(slot_num > osb->max_slots);		BUG_ON(slot_num >= osb->max_slots);

	if (!si->si_slots[slot_num].sl_valid)		if (!si->si_slots[slot_num].sl_valid)
	return -ENOENT;		return -ENOENT;