Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 50d89980 authored by Florian Fainelli's avatar Florian Fainelli Committed by David S. Miller
Browse files

net: phy: bcm7xxx: Fix shadow mode 2 disabling 



The clear and set masks in the call to phy_set_clr_bits() called from
bcm7xxx_config_init() are inverted. We need to fix this by swapping the two
arguments, that is, set 0 bits, but clear the shade mode 2 enable bit.

Fixes: b560a58c ("net: phy: add Broadcom BCM7xxx internal PHY driver")
Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5d8e498f

drivers/net/phy/bcm7xxx.c

+1 −1
Original line number Diff line number Diff line
@@ -270,7 +270,7 @@ static int bcm7xxx_config_init(struct phy_device *phydev) 
	phy_write(phydev, MII_BCM7XXX_100TX_FALSE_CAR, 0x7555);



	/* reset shadow mode 2 */

	ret = phy_set_clr_bits(phydev, MII_BCM7XXX_TEST, MII_BCM7XXX_SHD_MODE_2, 0);

	ret = phy_set_clr_bits(phydev, MII_BCM7XXX_TEST, 0, MII_BCM7XXX_SHD_MODE_2);

	if (ret < 0)

		return ret;