Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 50d6ec55 authored by Ben Hutchings's avatar Ben Hutchings Committed by David S. Miller
Browse files

sfc: QT2025C: Add error message for suspected bad SFP+ cables 



Some cables have EEPROMs that conflict with the PHY's on-board EEPROM
so it cannot load firmware.

Signed-off-by: default avatarBen Hutchings <bhutchings@solarflare.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1a1284ef

drivers/net/sfc/qt202x_phy.c

+7 −1
Original line number Diff line number Diff line
@@ -87,8 +87,14 @@ static int qt2025c_wait_heartbeat(struct efx_nic *efx) 
			old_counter = counter;

		else if (counter != old_counter)

			break;

		if (time_after(jiffies, timeout))

		if (time_after(jiffies, timeout)) {

			/* Some cables have EEPROMs that conflict with the

			 * PHY's on-board EEPROM so it cannot load firmware */

			EFX_ERR(efx, "If an SFP+ direct attach cable is"

				" connected, please check that it complies"

				" with the SFP+ specification\n");

			return -ETIMEDOUT;

		}

		msleep(QT2025C_HEARTB_WAIT);

	}