Commit 4fac507d authored Feb 15, 2021 by Colin Ian King Committed by Greg Kroah-Hartman Mar 03, 2021

b43: N-PHY: Fix the update of coef for the PHY revision >= 3case

[ Upstream commit 4773acf3d4b50768bf08e9e97a204819e9ea0895 ]

The documentation for the PHY update [1] states:

Loop 4 times with index i

    If PHY Revision >= 3
        Copy table[i] to coef[i]
    Otherwise
        Set coef[i] to 0

the copy of the table to coef is currently implemented the wrong way
around, table is being updated from uninitialized values in coeff.
Fix this by swapping the assignment around.

[1] https://bcm-v4.sipsolutions.net/802.11/PHY/N/RestoreCal/



Fixes: 2f258b74 ("b43: N-PHY: implement restoring general configuration")
Addresses-Coverity: ("Uninitialized scalar variable")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 14d12b1b

drivers/net/wireless/broadcom/b43/phy_n.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -5320,7 +5320,7 @@ static void b43_nphy_restore_cal(struct b43_wldev *dev)

		for (i = 0; i < 4; i++) {
		if (dev->phy.rev >= 3)
		table[i] = coef[i];
		coef[i] = table[i];
		else
		coef[i] = 0;
		}