Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4dbc9ca2 authored by Thomas Gleixner's avatar Thomas Gleixner
Browse files

genirq: Do not mask oneshot edge type interrupts 



Masking oneshot edge type interrupts is wrong as we might lose an
interrupt which is issued when the threaded handler is handling the
device. We can keep the irq unmasked safely as with edge type
interrupts there is no danger of interrupt floods. If the threaded
handler has not yet finished then IRQTF_RUNTHREAD is set which will
keep the handler thread active.

Debugged and verified in preempt-rt.

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent 399b5da2

kernel/irq/chip.c

+2 −7
Original line number Original line Diff line number Diff line
@@ -548,13 +548,8 @@ handle_edge_irq(unsigned int irq, struct irq_desc *desc) 
	kstat_incr_irqs_this_cpu(irq, desc);

	kstat_incr_irqs_this_cpu(irq, desc);





	/* Start handling the irq */

	/* Start handling the irq */

	if (unlikely(desc->status & IRQ_ONESHOT)) {

		desc->status |= IRQ_MASKED;

		mask_ack_irq(desc, irq);

	} else {

	if (desc->chip->ack)

	if (desc->chip->ack)

		desc->chip->ack(irq);

		desc->chip->ack(irq);

	}





	/* Mark the IRQ currently in progress.*/

	/* Mark the IRQ currently in progress.*/

	desc->status |= IRQ_INPROGRESS;

	desc->status |= IRQ_INPROGRESS;