Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4d4c4dc3 authored by Lior David's avatar Lior David Committed by Kalle Valo
Browse files

wil6210: missing reinit_completion in wmi_call 



The code in wmi_call uses the wil->wmi_call completion
structure to wait for a reply.
In some scenarios, complete was called twice on the
completion structure. This happened mainly with a disconnect
event which can arrive both unsolicited and as a reply to
a disconnect request. In this case the completion structure
was left marked as "done" and the next wmi_call returned
immediately with a corrupted reply buffer. This caused
unexpected results including crashes.
Fix this by adding the missing call to reinit_completion.

Signed-off-by: default avatarLior David <qca_liord@qca.qualcomm.com>
Signed-off-by: default avatarMaya Erez <qca_merez@qca.qualcomm.com>
Signed-off-by: default avatarKalle Valo <kvalo@qca.qualcomm.com>
parent 0d2370e9

drivers/net/wireless/ath/wil6210/wmi.c

+1 −0
Original line number Diff line number Diff line
@@ -957,6 +957,7 @@ int wmi_call(struct wil6210_priv *wil, u16 cmdid, void *buf, u16 len, 
	wil->reply_id = reply_id;

	wil->reply_buf = reply;

	wil->reply_size = reply_size;

	reinit_completion(&wil->wmi_call);

	spin_unlock(&wil->wmi_ev_lock);



	rc = __wmi_send(wil, cmdid, buf, len);