Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4c94dece authored by Tejun Heo's avatar Tejun Heo Committed by Jens Axboe
Browse files

block: don't init rq fields unnecessarily 



blk_get_request() always returns properly zeroed requests.  Don't set
fields to zero/NULL unnecessarily.

[ Impact: cleanup ]

Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Signed-off-by: default avatarJens Axboe <jens.axboe@oracle.com>
parent 9fd8d0e1

block/scsi_ioctl.c

+0 −2
Original line number Original line Diff line number Diff line
@@ -500,8 +500,6 @@ static int __blk_send_generic(struct request_queue *q, struct gendisk *bd_disk, 




	rq = blk_get_request(q, WRITE, __GFP_WAIT);

	rq = blk_get_request(q, WRITE, __GFP_WAIT);

	rq->cmd_type = REQ_TYPE_BLOCK_PC;

	rq->cmd_type = REQ_TYPE_BLOCK_PC;

	rq->data_len = 0;

	rq->extra_len = 0;

	rq->timeout = BLK_DEFAULT_SG_TIMEOUT;

	rq->timeout = BLK_DEFAULT_SG_TIMEOUT;

	rq->cmd[0] = cmd;

	rq->cmd[0] = cmd;

	rq->cmd[4] = data;

	rq->cmd[4] = data;