Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4bc43652 authored by Adrian Bunk's avatar Adrian Bunk Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB (5933): Dvb-usb/af9005-fe.c: error check fixes 



This patch:
- adds a missing error check and
- removes an error check that could never be true

Both spotted by the Coverity checker.

Signed-off-by: default avatarAdrian Bunk <bunk@stusta.de>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Acked-by: default avatarLuca Olivetti <luca@ventoso.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@infradead.org>
parent 639ffd2d

drivers/media/dvb/dvb-usb/af9005-fe.c

+4 −6
Original line number Diff line number Diff line
@@ -343,7 +343,7 @@ static int af9005_reset_pre_viterbi(struct dvb_frontend *fe) 
				       1 & 0xff);

	if (ret)

		return ret;

	af9005_write_ofdm_register(state->d, xd_p_fec_super_frm_unit_15_8,

	ret = af9005_write_ofdm_register(state->d, xd_p_fec_super_frm_unit_15_8,

					 1 >> 8);

	if (ret)

		return ret;
@@ -879,10 +879,8 @@ static int af9005_fe_init(struct dvb_frontend *fe) 
	     af9005_write_register_bits(state->d, xd_I2C_reg_ofdm_rst,

					reg_ofdm_rst_pos, reg_ofdm_rst_len, 1)))

		return ret;

	if ((ret =

	     af9005_write_register_bits(state->d, xd_I2C_reg_ofdm_rst,

					reg_ofdm_rst_pos, reg_ofdm_rst_len, 0)))

		return ret;

	ret = af9005_write_register_bits(state->d, xd_I2C_reg_ofdm_rst,

					 reg_ofdm_rst_pos, reg_ofdm_rst_len, 0);



	if (ret)

		return ret;