Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4b8a8262 authored by Markus Elfring's avatar Markus Elfring Committed by Jiri Kosina
Browse files

HID: picoLCD: Deletion of unnecessary checks before three function calls 



The functions backlight_device_unregister(), lcd_device_unregister() and
rc_unregister_device() test whether their argument is NULL and then
return immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Reviewed-by: default avatarBruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.com>
parent 67db8a80

drivers/hid/hid-picolcd_backlight.c

+1 −2
Original line number Diff line number Diff line
@@ -94,7 +94,6 @@ void picolcd_exit_backlight(struct picolcd_data *data) 
	struct backlight_device *bdev = data->backlight;



	data->backlight = NULL;

	if (bdev)

	backlight_device_unregister(bdev);

}

drivers/hid/hid-picolcd_cir.c

+1 −2
Original line number Diff line number Diff line
@@ -145,7 +145,6 @@ void picolcd_exit_cir(struct picolcd_data *data) 
	struct rc_dev *rdev = data->rc_dev;



	data->rc_dev = NULL;

	if (rdev)

	rc_unregister_device(rdev);

}

drivers/hid/hid-picolcd_lcd.c

+1 −2
Original line number Diff line number Diff line
@@ -92,7 +92,6 @@ void picolcd_exit_lcd(struct picolcd_data *data) 
	struct lcd_device *ldev = data->lcd;



	data->lcd = NULL;

	if (ldev)

	lcd_device_unregister(ldev);

}