Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4b44a1ed authored by Kim, Milo's avatar Kim, Milo Committed by Anton Vorontsov
Browse files

lp8788-charger: Use PAGE_SIZE for the sysfs read operation 



The sysfs allocates PAGE_SIZE. It is used by each R/W operation method.
Use it instead of another buffer size.

Signed-off-by: default avatarMilo(Woogyom) Kim <milo.kim@ti.com>
Signed-off-by: default avatarAnton Vorontsov <anton@enomsg.org>
parent feeb3a92

drivers/power/lp8788-charger.c

+3 −5
Original line number Original line Diff line number Diff line
@@ -49,7 +49,6 @@ 
#define LP8788_CHG_START		0x11

#define LP8788_CHG_START		0x11

#define LP8788_CHG_END			0x1C

#define LP8788_CHG_END			0x1C





#define LP8788_BUF_SIZE			40

#define LP8788_ISEL_MAX			23

#define LP8788_ISEL_MAX			23

#define LP8788_ISEL_STEP		50

#define LP8788_ISEL_STEP		50

#define LP8788_VTERM_MIN		4100

#define LP8788_VTERM_MIN		4100
@@ -633,7 +632,7 @@ static ssize_t lp8788_show_charger_status(struct device *dev, 
	lp8788_read_byte(pchg->lp, LP8788_CHG_STATUS, &data);

	lp8788_read_byte(pchg->lp, LP8788_CHG_STATUS, &data);

	state = (data & LP8788_CHG_STATE_M) >> LP8788_CHG_STATE_S;

	state = (data & LP8788_CHG_STATE_M) >> LP8788_CHG_STATE_S;





	return scnprintf(buf, LP8788_BUF_SIZE, "%s\n", desc[state]);

	return scnprintf(buf, PAGE_SIZE, "%s\n", desc[state]);

}

}





static ssize_t lp8788_show_eoc_time(struct device *dev,

static ssize_t lp8788_show_eoc_time(struct device *dev,
@@ -647,7 +646,7 @@ static ssize_t lp8788_show_eoc_time(struct device *dev, 
	lp8788_read_byte(pchg->lp, LP8788_CHG_EOC, &val);

	lp8788_read_byte(pchg->lp, LP8788_CHG_EOC, &val);

	val = (val & LP8788_CHG_EOC_TIME_M) >> LP8788_CHG_EOC_TIME_S;

	val = (val & LP8788_CHG_EOC_TIME_M) >> LP8788_CHG_EOC_TIME_S;





	return scnprintf(buf, LP8788_BUF_SIZE, "End Of Charge Time: %s\n",

	return scnprintf(buf, PAGE_SIZE, "End Of Charge Time: %s\n",

			stime[val]);

			stime[val]);

}

}
@@ -667,8 +666,7 @@ static ssize_t lp8788_show_eoc_level(struct device *dev, 
	val = (val & LP8788_CHG_EOC_LEVEL_M) >> LP8788_CHG_EOC_LEVEL_S;

	val = (val & LP8788_CHG_EOC_LEVEL_M) >> LP8788_CHG_EOC_LEVEL_S;

	level = mode ? abs_level[val] : relative_level[val];

	level = mode ? abs_level[val] : relative_level[val];





	return scnprintf(buf, LP8788_BUF_SIZE, "End Of Charge Level: %s\n",

	return scnprintf(buf, PAGE_SIZE, "End Of Charge Level: %s\n", level);

			level);

}

}





static DEVICE_ATTR(charger_status, S_IRUSR, lp8788_show_charger_status, NULL);

static DEVICE_ATTR(charger_status, S_IRUSR, lp8788_show_charger_status, NULL);