Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4b28038f authored by Vladimir Zapolskiy's avatar Vladimir Zapolskiy Committed by Bjorn Andersson
Browse files

remoteproc: st: fix check of syscon_regmap_lookup_by_phandle() return value 



syscon_regmap_lookup_by_phandle() returns either a valid pointer to
struct regmap or ERR_PTR() error value, check for NULL is invalid and
on error path may lead to oops, the change corrects the check.

Signed-off-by: default avatarVladimir Zapolskiy <vz@mleia.com>
Acked-by: default avatarLee Jones <lee.jones@linaro.org>
Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
parent f55532a0

drivers/remoteproc/st_remoteproc.c

+2 −2
Original line number Diff line number Diff line
@@ -189,9 +189,9 @@ static int st_rproc_parse_dt(struct platform_device *pdev) 
	}



	ddata->boot_base = syscon_regmap_lookup_by_phandle(np, "st,syscfg");

	if (!ddata->boot_base) {

	if (IS_ERR(ddata->boot_base)) {

		dev_err(dev, "Boot base not found\n");

		return -EINVAL;

		return PTR_ERR(ddata->boot_base);

	}



	err = of_property_read_u32_index(np, "st,syscfg", 1,