Commit 4ab7f913 authored May 15, 2015 by Florian Fainelli Committed by David S. Miller May 17, 2015

net: dsa: bcm_sf2: properly propagate carrier down state for MoCA



MoCA interfaces require the use of an user-space daemon (mocad) which
will typically use cmd->autoneg to force the link. This is causing other
network manager applications not to get proper carrier down
notifications because of the following sequence of events:

- link down interrupt is received, link is set to 0 by the interrupt
  handler
- fixed_link update callback runs and updates the BMSR register
  accordingly
- PHY library polls the PHY for link status, sees the link is down,
  proceeds with reporting that
- mocad gets notified of the link state and call phy_ethtool_sset()
  with cmd->autoneg set to the link status (0)
- phy_start_aneg() is called at the end of phy_ethtool_sset() and sets
  the PHY state to PHY_FORCING

Just make sure we notify the interface carrier appropriately when we
detect that the link is down in our fixed_link update callback. This is
made local to the bcm_sf2 driver as the PHY library does the right thing
in any case. This is similar to the GENET change introduced in
54d7c01d ("net: bcmgenet: enable MoCA
link state change detection").

Fixes: 246d7f77 ("net: dsa: add Broadcom SF2 switch driver")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 74b80e84

drivers/net/dsa/bcm_sf2.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -911,6 +911,13 @@ static void bcm_sf2_sw_fixed_link_update(struct dsa_switch *ds, int port,
		*/
		if (port == 7) {
		status->link = priv->port_sts[port].link;
		/* For MoCA interfaces, also force a link down notification
		* since some version of the user-space daemon (mocad) use
		* cmd->autoneg to force the link, which messes up the PHY
		* state machine and make it go in PHY_FORCING state instead.
		*/
		if (!status->link)
		netif_carrier_off(ds->ports[port]);
		status->duplex = 1;
		} else {
		status->link = 1;