Commit 4a8557de authored Apr 25, 2017 by Markus Elfring Committed by Sebastian Reichel Jun 08, 2017

HSI: omap_ssi: Use devm_kcalloc() in ssi_add_controller()



* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "devm_kcalloc".

  This issue was detected by using the Coccinelle software.

* Replace the specification of a data type by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>

parent 34b2486d

drivers/hsi/controllers/omap_ssi_core.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -421,8 +421,8 @@ static int ssi_add_controller(struct hsi_controller *ssi,
		goto out_err;
		}

		omap_ssi->port = devm_kzalloc(&ssi->device,
		sizeof(struct omap_ssi_port ) ssi->num_ports, GFP_KERNEL);
		omap_ssi->port = devm_kcalloc(&ssi->device, ssi->num_ports,
		sizeof(*omap_ssi->port), GFP_KERNEL);
		if (!omap_ssi->port) {
		err = -ENOMEM;
		goto out_err;