Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 496e65f6 authored by Rameshwar Prasad Sahu's avatar Rameshwar Prasad Sahu Committed by Greg Kroah-Hartman
Browse files

ata: fixes kernel crash while tracing ata_eh_link_autopsy event 



commit f1601113ddc0339a745e702f4fb1ca37d4875e65 upstream.

When tracing ata link error event, the kernel crashes when the disk is
removed due to NULL pointer access by trace_ata_eh_link_autopsy API.
This occurs as the dev is NULL when the disk disappeared. This patch
fixes this crash by calling trace_ata_eh_link_autopsy only if "dev"
is not NULL.

v2 changes:
 Removed direct passing "link" pointer instead of "dev" in trace API.

Signed-off-by: default avatarRameshwar Prasad Sahu <rsahu@apm.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Fixes: 255c03d1 ("libata: Add tracepoints")
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2f5be981

drivers/ata/libata-eh.c

+1 −1
Original line number Diff line number Diff line
@@ -2264,8 +2264,8 @@ static void ata_eh_link_autopsy(struct ata_link *link) 
		if (dev->flags & ATA_DFLAG_DUBIOUS_XFER)

			eflags |= ATA_EFLAG_DUBIOUS_XFER;

		ehc->i.action |= ata_eh_speed_down(dev, eflags, all_err_mask);

	}

		trace_ata_eh_link_autopsy(dev, ehc->i.action, all_err_mask);

	}

	DPRINTK("EXIT\n");

}