Commit 49477939 authored Sep 08, 2016 by Bjorn Helgaas

PCI: pciehp: Remove unnecessary guard



In pcie_isr(), we return early if no status bits other than
PCI_EXP_SLTSTA_CC are set.  This was introduced by dbd79aed ("pciehp:
fix NULL dereference in interrupt handler"), but it is no longer necessary
because all the subsequent pcie_isr() code is already predicated on a
status bit being set.

Remove the unnecessary test for ~PCI_EXP_SLTSTA_CC.  No functional change
intended.

Tested-by: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>

parent 69bd3c5b

drivers/pci/hotplug/pciehp_hpc.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -590,9 +590,6 @@ static irqreturn_t pciehp_isr(int irq, void *dev_id)
		}
		}

		if (!(events & ~PCI_EXP_SLTSTA_CC))
		return IRQ_HANDLED;

		/* Check Attention Button Pressed */
		if (events & PCI_EXP_SLTSTA_ABP) {
		ctrl_info(ctrl, "Button pressed on Slot(%s)\n",