Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 480ce08a authored by Yan, Zheng's avatar Yan, Zheng Committed by Ilya Dryomov
Browse files

FS-Cache: make check_consistency callback return int 



__fscache_check_consistency() calls check_consistency() callback
and return the callback's return value. But the return type of
check_consistency() is bool. So __fscache_check_consistency()
return 1 if the cache is inconsistent. This is inconsistent with
the document.

Signed-off-by: default avatarYan, Zheng <zyan@redhat.com>
Acked-by: default avatarDavid Howells <dhowells@redhat.com>
parent d2138455

fs/cachefiles/interface.c

+1 −1
Original line number Diff line number Diff line
@@ -380,7 +380,7 @@ static void cachefiles_sync_cache(struct fscache_cache *_cache) 
 * check if the backing cache is updated to FS-Cache

 * - called by FS-Cache when evaluates if need to invalidate the cache

 */

static bool cachefiles_check_consistency(struct fscache_operation *op)

static int cachefiles_check_consistency(struct fscache_operation *op)

{

	struct cachefiles_object *object;

	struct cachefiles_cache *cache;

include/linux/fscache-cache.h

+1 −1
Original line number Diff line number Diff line
@@ -241,7 +241,7 @@ struct fscache_cache_ops { 


	/* check the consistency between the backing cache and the FS-Cache

	 * cookie */

	bool (*check_consistency)(struct fscache_operation *op);

	int (*check_consistency)(struct fscache_operation *op);



	/* store the updated auxiliary data on an object */

	void (*update_object)(struct fscache_object *object);