Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 47efeb52 authored by Sudip Mukherjee's avatar Sudip Mukherjee Committed by Mauro Carvalho Chehab
Browse files

[media] media: davinci: vpbe: missing clk_put 



we are getting struct clk using clk_get before calling
clk_prepare_enable. but if clk_prepare_enable fails, then we are
jumping to fail_mutex_unlock where we are just unlocking the mutex,
but we are not freeing the clock source.
this patch just adds a call to clk_put before jumping to
fail_mutex_unlock.

Signed-off-by: default avatarSudip Mukherjee <sudip@vectorindia.org>
Acked-by: default avatarLad, Prabhakar <prabhakar.csengg@gmail.com>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent 24c4942d

drivers/media/platform/davinci/vpbe.c

+1 −0
Original line number Diff line number Diff line
@@ -625,6 +625,7 @@ static int vpbe_initialize(struct device *dev, struct vpbe_device *vpbe_dev) 
		}

		if (clk_prepare_enable(vpbe_dev->dac_clk)) {

			ret =  -ENODEV;

			clk_put(vpbe_dev->dac_clk);

			goto fail_mutex_unlock;

		}

	}