Commit 47cafb13 authored Dec 15, 2018 by Takashi Sakamoto Committed by Greg Kroah-Hartman Jan 09, 2019

ALSA: fireface: fix for state to fetch PCM frames



commit 3d16200a3e55a39caa1c88419cb559c00316f721 upstream.

According to my memo at hand and saved records, writing 0x00000001 to
SND_FF_REG_FETCH_PCM_FRAMES disables fetching PCM frames in corresponding
channel, however current implement uses reversed logic. This results in
muted volume in device side during playback.

This commit corrects the bug.

Cc: <stable@vger.kernel.org> # v4.12+
Fixes: 76fdb3a9 ('ALSA: fireface: add support for Fireface 400')
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 91056ae4

sound/firewire/fireface/ff-protocol-ff400.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -152,7 +152,7 @@ static int ff400_switch_fetching_mode(struct snd_ff *ff, bool enable)
	if (reg == NULL)		if (reg == NULL)
	return -ENOMEM;		return -ENOMEM;

	if (enable) {		if (!enable) {
	/*		/*
	* Each quadlet is corresponding to data channels in a data		* Each quadlet is corresponding to data channels in a data
	* blocks in reverse order. Precisely, quadlets for available		* blocks in reverse order. Precisely, quadlets for available