Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4694e6e3 authored by Philippe Reynes's avatar Philippe Reynes Committed by David S. Miller
Browse files

net: ethernet: arc: emac: use phy_ethtool_{get|set}_link_ksettings 



There are two generics functions phy_ethtool_{get|set}_link_ksettings,
so we can use them instead of defining the same code in the driver.

Signed-off-by: default avatarPhilippe Reynes <tremyfr@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 01dea536

drivers/net/ethernet/arc/emac_main.c

+2 −38
Original line number Diff line number Diff line
@@ -79,42 +79,6 @@ static void arc_emac_adjust_link(struct net_device *ndev) 
		phy_print_status(phy_dev);

}



/**

 * arc_emac_get_settings - Get PHY settings.

 * @ndev:	Pointer to net_device structure.

 * @cmd:	Pointer to ethtool_cmd structure.

 *

 * This implements ethtool command for getting PHY settings. If PHY could

 * not be found, the function returns -ENODEV. This function calls the

 * relevant PHY ethtool API to get the PHY settings.

 * Issue "ethtool ethX" under linux prompt to execute this function.

 */

static int arc_emac_get_settings(struct net_device *ndev,

				 struct ethtool_cmd *cmd)

{

	return phy_ethtool_gset(ndev->phydev, cmd);

}



/**

 * arc_emac_set_settings - Set PHY settings as passed in the argument.

 * @ndev:	Pointer to net_device structure.

 * @cmd:	Pointer to ethtool_cmd structure.

 *

 * This implements ethtool command for setting various PHY settings. If PHY

 * could not be found, the function returns -ENODEV. This function calls the

 * relevant PHY ethtool API to set the PHY.

 * Issue e.g. "ethtool -s ethX speed 1000" under linux prompt to execute this

 * function.

 */

static int arc_emac_set_settings(struct net_device *ndev,

				 struct ethtool_cmd *cmd)

{

	if (!capable(CAP_NET_ADMIN))

		return -EPERM;



	return phy_ethtool_sset(ndev->phydev, cmd);

}



/**

 * arc_emac_get_drvinfo - Get EMAC driver information.

 * @ndev:	Pointer to net_device structure.
@@ -133,10 +97,10 @@ static void arc_emac_get_drvinfo(struct net_device *ndev, 
}



static const struct ethtool_ops arc_emac_ethtool_ops = {

	.get_settings	= arc_emac_get_settings,

	.set_settings	= arc_emac_set_settings,

	.get_drvinfo	= arc_emac_get_drvinfo,

	.get_link	= ethtool_op_get_link,

	.get_link_ksettings = phy_ethtool_get_link_ksettings,

	.set_link_ksettings = phy_ethtool_set_link_ksettings,

};



#define FIRST_OR_LAST_MASK	(FIRST_MASK | LAST_MASK)