Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 45adfef7 authored by Sage Weil's avatar Sage Weil Committed by Al Viro
Browse files

hpfs: remove unnecessary dentry_unhash on rmdir, dir rename 



Hpfs has no problems with references to unlinked directories.

We leave one dentry_unhash call in place, in hpfs_unlink's strange path
where it tries to truncate a file because the disk is full.  I'm not sure
what the full story is there.

CC: Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>
Signed-off-by: default avatarSage Weil <sage@newdream.net>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent b80d2c22

fs/hpfs/namei.c

+0 −5
Original line number Diff line number Diff line
@@ -439,8 +439,6 @@ static int hpfs_rmdir(struct inode *dir, struct dentry *dentry) 
	int err;

	int r;



	dentry_unhash(dentry);



	hpfs_adjust_length(name, &len);

	hpfs_lock(dir->i_sb);

	err = -ENOENT;
@@ -535,9 +533,6 @@ static int hpfs_rename(struct inode *old_dir, struct dentry *old_dentry, 
	struct fnode *fnode;

	int err;



	if (new_inode && S_ISDIR(new_inode->i_mode))

		dentry_unhash(new_dentry);



	if ((err = hpfs_chk_name(new_name, &new_len))) return err;

	err = 0;

	hpfs_adjust_length(old_name, &old_len);