Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 45938bcf authored by Bala Venkatesh's avatar Bala Venkatesh Committed by nshrivas
Browse files

qcacmn: Take vdev ref only if vdev is not NULL 

In functions ucfg_tdls_update_rx_pkt_cnt and
ucfg_tdls_update_tx_pkt_cnt, driver tries
to get the vdev ref, even if it is NULL.
This can result in assert.

Change-Id: I62b3a9b088324e06518e82203092a2ac9098ac13
CRs-Fixed: 2414060
parent 4cdf5b88

umac/tdls/dispatcher/src/wlan_tdls_ucfg_api.c

+0 −12
Original line number Diff line number Diff line
@@ -833,26 +833,14 @@ void ucfg_tdls_update_rx_pkt_cnt(struct wlan_objmgr_vdev *vdev, 
				 struct qdf_mac_addr *mac_addr,

				 struct qdf_mac_addr *dest_mac_addr)

{

	QDF_STATUS status;

	status = wlan_objmgr_vdev_try_get_ref(vdev, WLAN_TDLS_NB_ID);

	if (status != QDF_STATUS_SUCCESS)

		return;

	tdls_update_rx_pkt_cnt(vdev, mac_addr, dest_mac_addr);



	wlan_objmgr_vdev_release_ref(vdev, WLAN_TDLS_NB_ID);

}



void ucfg_tdls_update_tx_pkt_cnt(struct wlan_objmgr_vdev *vdev,

				 struct qdf_mac_addr *mac_addr)

{

	QDF_STATUS status;

	status = wlan_objmgr_vdev_try_get_ref(vdev, WLAN_TDLS_NB_ID);

	if (status != QDF_STATUS_SUCCESS)

		return;

	tdls_update_tx_pkt_cnt(vdev, mac_addr);



	wlan_objmgr_vdev_release_ref(vdev, WLAN_TDLS_NB_ID);



}



QDF_STATUS ucfg_tdls_antenna_switch(struct wlan_objmgr_vdev *vdev,