Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 45735326 authored by Jisheng Zhang's avatar Jisheng Zhang Committed by Daniel Lezcano
Browse files

clockevents/drivers/dw_apb_timer: Implement ->set_state_oneshot_stopped() 



The dw_apb_timer only "supports PERIODIC mode and their drivers emulate
ONESHOT over that" as described in commit 8fff52fd ("clockevents:
Introduce CLOCK_EVT_STATE_ONESHOT_STOPPED state").

Inspired by Viresh, I think the dw_apb_timer also needs to implement
the set_state_oneshot_stopped() which is called by the clkevt core,
when the next event is required at an expiry time of 'KTIME_MAX'. This
normally happens with NO_HZ_{IDLE|FULL} in both LOWRES/HIGHRES modes.

This patch makes the clockevent device to stop on such an event, to
avoid spurious interrupts, as explained by the above commit.

Signed-off-by: default avatarJisheng Zhang <jszhang@marvell.com>
Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
Reviewed-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
parent 86d34732

drivers/clocksource/dw_apb_timer.c

+1 −0
Original line number Diff line number Diff line
@@ -264,6 +264,7 @@ dw_apb_clockevent_init(int cpu, const char *name, unsigned rating, 
	dw_ced->ced.set_state_shutdown = apbt_shutdown;

	dw_ced->ced.set_state_periodic = apbt_set_periodic;

	dw_ced->ced.set_state_oneshot = apbt_set_oneshot;

	dw_ced->ced.set_state_oneshot_stopped = apbt_shutdown;

	dw_ced->ced.tick_resume = apbt_resume;

	dw_ced->ced.set_next_event = apbt_next_event;

	dw_ced->ced.irq = dw_ced->timer.irq;