Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 456fdbcb authored by Oleg Nesterov's avatar Oleg Nesterov
Browse files

uprobes/tracing: Kill the pointless seq_print_ip_sym() call 



seq_print_ip_sym(ip) in print_uprobe_event() is pointless,
kallsyms_lookup(ip) can not resolve a user-space address.

Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
Acked-by: default avatarSrikar Dronamraju <srikar@linux.vnet.ibm.com>
Tested-by: default avatarAnton Arapov <anton@redhat.com>
parent 07720b63

kernel/trace/trace_uprobe.c

+1 −7
Original line number Diff line number Diff line
@@ -531,13 +531,7 @@ print_uprobe_event(struct trace_iterator *iter, int flags, struct trace_event *e 
	field = (struct uprobe_trace_entry_head *)iter->ent;

	tu = container_of(event, struct trace_uprobe, call.event);



	if (!trace_seq_printf(s, "%s: (", tu->call.name))

		goto partial;



	if (!seq_print_ip_sym(s, field->ip, flags | TRACE_ITER_SYM_OFFSET))

		goto partial;



	if (!trace_seq_puts(s, ")"))

	if (!trace_seq_printf(s, "%s: (0x%lx)", tu->call.name, field->ip))

		goto partial;



	data = (u8 *)&field[1];