Commit 45024646 authored Nov 08, 2013 by Rashika Kheria Committed by Greg Kroah-Hartman Nov 10, 2013

Staging: rtl8192e: Fix incorrect type in assignment in rtl819x_BAProc.c

This patch fixes the following Sparse warnings in
rtl819x_BAProc.c-

drivers/staging/rtl8192e/rtl819x_BAProc.c:118:21: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtl819x_BAProc.c:118:21: expected unsigned short [unsigned] [usertype] tmp
drivers/staging/rtl8192e/rtl819x_BAProc.c:118:21: got restricted __le16 [usertype] <noident>

drivers/staging/rtl8192e/rtl819x_BAProc.c:122:13: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtl819x_BAProc.c:122:13: expected unsigned short [unsigned] [addressable] [usertype] tmp
drivers/staging/rtl8192e/rtl819x_BAProc.c:122:13: got restricted __le16 [usertype] <noident>

drivers/staging/rtl8192e/rtl819x_BAProc.c:125:13: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtl819x_BAProc.c:125:13: expected unsigned short [unsigned] [addressable] [usertype] tmp
drivers/staging/rtl8192e/rtl819x_BAProc.c:125:13: got restricted __le16 [usertype] <noident>

drivers/staging/rtl8192e/rtl819x_BAProc.c:181:13: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtl819x_BAProc.c:181:13: expected unsigned short [unsigned] [usertype] tmp
drivers/staging/rtl8192e/rtl819x_BAProc.c:181:13: got restricted __le16 [usertype] <noident>

drivers/staging/rtl8192e/rtl819x_BAProc.c:184:13: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8192e/rtl819x_BAProc.c:184:13: expected unsigned short [unsigned] [addressable] [usertype] tmp
drivers/staging/rtl8192e/rtl819x_BAProc.c:184:13: got restricted __le16 [usertype] <noident>

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent c5654c0b

drivers/staging/rtl8192e/rtl819x_BAProc.c

+5 −5

Original line number	Diff line number	Diff line
		@@ -115,14 +115,14 @@ static struct sk_buff rtllib_ADDBA(struct rtllib_device ieee, u8 *Dst,

		if (ACT_ADDBARSP == type) {
		RT_TRACE(COMP_DBG, "====>to send ADDBARSP\n");
		tmp = cpu_to_le16(StatusCode);
		tmp = StatusCode;
		memcpy(tag, (u8 *)&tmp, 2);
		tag += 2;
		}
		tmp = cpu_to_le16(pBA->BaParamSet.shortData);
		tmp = pBA->BaParamSet.shortData;
		memcpy(tag, (u8 *)&tmp, 2);
		tag += 2;
		tmp = cpu_to_le16(pBA->BaTimeoutValue);
		tmp = pBA->BaTimeoutValue;
		memcpy(tag, (u8 *)&tmp, 2);
		tag += 2;

		@@ -178,10 +178,10 @@ static struct sk_buff rtllib_DELBA(struct rtllib_device ieee, u8 *dst,
		*tag ++= ACT_CAT_BA;
		*tag ++= ACT_DELBA;

		tmp = cpu_to_le16(DelbaParamSet.shortData);
		tmp = DelbaParamSet.shortData;
		memcpy(tag, (u8 *)&tmp, 2);
		tag += 2;
		tmp = cpu_to_le16(ReasonCode);
		tmp = ReasonCode;
		memcpy(tag, (u8 *)&tmp, 2);
		tag += 2;