Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 44b82dde authored by Greg Rose's avatar Greg Rose Committed by Jeff Kirsher
Browse files

ixgbe: Fix bogus error message 



If the VF sends a MACVLAN request with index of zero then it is not
actually trying to add a filter.  Check the index value and only
indicate that operation is not allowed when the VF is actually trying
to add a filter.

Signed-off-by: default avatarGreg Rose <gregory.v.rose@intel.com>
Tested-by: default avatarSibai Li <sibai.li@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 3ebe8fde

drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c

+3 −3
Original line number Diff line number Diff line
@@ -640,14 +640,14 @@ static int ixgbe_rcv_msg_from_vf(struct ixgbe_adapter *adapter, u32 vf) 
		}

		break;

	case IXGBE_VF_SET_MACVLAN:

		if (adapter->vfinfo[vf].pf_set_mac) {

		index = (msgbuf[0] & IXGBE_VT_MSGINFO_MASK) >>

			IXGBE_VT_MSGINFO_SHIFT;

		if (adapter->vfinfo[vf].pf_set_mac && index > 0) {

			e_warn(drv, "VF %d requested MACVLAN filter but is "

				    "administratively denied\n", vf);

			retval = -1;

			break;

		}

		index = (msgbuf[0] & IXGBE_VT_MSGINFO_MASK) >>

			IXGBE_VT_MSGINFO_SHIFT;

		/*

		 * If the VF is allowed to set MAC filters then turn off

		 * anti-spoofing to avoid false positives.  An index