Commit 43b6329f authored Feb 11, 2014 by Florian Fainelli Committed by David S. Miller Feb 12, 2014

net: phy: use network device in phy_print_status



phy_print_status() currently uses dev_name(&phydev->dev) which will
usually result in printing something along those lines for Device Tree
aware drivers:

libphy: f0b60000.etherne:0a - Link is Down
libphy: f0ba0000.etherne:00 - Link is Up - 1000/Full

This is not terribly useful for network administrators or users since we
expect a network interface name to be able to correlate link events with
interfaces. Update phy_print_status() to use netdev_info() with
phydev->attached_dev which is the backing network device for our PHY
device. The leading dash is removed since netdev_info() prefixes the
messages with "<interface>: " already.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 0e4767aa

drivers/net/phy/phy.c

+2 −3

Original line number	Original line	Diff line number	Diff line
	@@ -45,12 +45,11 @@
	void phy_print_status(struct phy_device *phydev)		void phy_print_status(struct phy_device *phydev)
	{		{
	if (phydev->link) {		if (phydev->link) {
	pr_info("%s - Link is Up - %d/%s\n",		netdev_info(phydev->attached_dev, "Link is Up - %d/%s\n",
	dev_name(&phydev->dev),
	phydev->speed,		phydev->speed,
	DUPLEX_FULL == phydev->duplex ? "Full" : "Half");		DUPLEX_FULL == phydev->duplex ? "Full" : "Half");
	} else {		} else {
	pr_info("%s - Link is Down\n", dev_name(&phydev->dev));		netdev_info(phydev->attached_dev, "Link is Down\n");
	}		}
	}		}
	EXPORT_SYMBOL(phy_print_status);		EXPORT_SYMBOL(phy_print_status);