Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 40ad9842 authored by Sven Eckelmann's avatar Sven Eckelmann Committed by Simon Wunderlich
Browse files

batman-adv: Remove ethtool msglevel functions 



batadv devices don't support msglevel. The ethtool stubs therefore returned
that it isn't supported. But instead, the complete function can be dropped
to avoid that bogus values are shown in ethtool.

Signed-off-by: default avatarSven Eckelmann <sven@narfation.org>
Acked-by: default avatarMarek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: default avatarSimon Wunderlich <sw@simonwunderlich.de>
parent 2f249e99

net/batman-adv/soft-interface.c

+0 −13
Original line number Diff line number Diff line
@@ -67,8 +67,6 @@ 
static int batadv_get_settings(struct net_device *dev, struct ethtool_cmd *cmd);

static void batadv_get_drvinfo(struct net_device *dev,

			       struct ethtool_drvinfo *info);

static u32 batadv_get_msglevel(struct net_device *dev);

static void batadv_set_msglevel(struct net_device *dev, u32 value);

static void batadv_get_strings(struct net_device *dev, u32 stringset, u8 *data);

static void batadv_get_ethtool_stats(struct net_device *dev,

				     struct ethtool_stats *stats, u64 *data);
@@ -77,8 +75,6 @@ static int batadv_get_sset_count(struct net_device *dev, int stringset); 
static const struct ethtool_ops batadv_ethtool_ops = {

	.get_settings = batadv_get_settings,

	.get_drvinfo = batadv_get_drvinfo,

	.get_msglevel = batadv_get_msglevel,

	.set_msglevel = batadv_set_msglevel,

	.get_link = ethtool_op_get_link,

	.get_strings = batadv_get_strings,

	.get_ethtool_stats = batadv_get_ethtool_stats,
@@ -1109,15 +1105,6 @@ static void batadv_get_drvinfo(struct net_device *dev, 
	strlcpy(info->bus_info, "batman", sizeof(info->bus_info));

}



static u32 batadv_get_msglevel(struct net_device *dev)

{

	return -EOPNOTSUPP;

}



static void batadv_set_msglevel(struct net_device *dev, u32 value)

{

}



/* Inspired by drivers/net/ethernet/dlink/sundance.c:1702

 * Declare each description string in struct.name[] to get fixed sized buffer

 * and compile time checking for strings longer than ETH_GSTRING_LEN.