Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3f1c241f authored by Maciej S. Szmigiero's avatar Maciej S. Szmigiero Committed by Mark Brown
Browse files

ASoC: fsl_ssi: mark SACNT register volatile 



SACNT register should be marked volatile since
its WR and RD bits are cleared by SSI after
completing the relevant operation.
This unbreaks AC'97 register access.

Fixes: 05cf2379 ("ASoC: fsl_ssi: Add driver suspend and resume to support MEGA Fast")

Signed-off-by: default avatarMaciej S. Szmigiero <mail@maciej.szmigiero.name>
Reviewed-by: default avatarFabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 34e684fa

sound/soc/fsl/fsl_ssi.c

+7 −1
Original line number Diff line number Diff line
@@ -146,6 +146,7 @@ static bool fsl_ssi_volatile_reg(struct device *dev, unsigned int reg) 
	case CCSR_SSI_SRX1:

	case CCSR_SSI_SISR:

	case CCSR_SSI_SFCSR:

	case CCSR_SSI_SACNT:

	case CCSR_SSI_SACADD:

	case CCSR_SSI_SACDAT:

	case CCSR_SSI_SATAG:
@@ -239,8 +240,9 @@ struct fsl_ssi_private { 
	unsigned int baudclk_streams;

	unsigned int bitclk_freq;



	/*regcache for SFCSR*/

	/* regcache for volatile regs */

	u32 regcache_sfcsr;

	u32 regcache_sacnt;



	/* DMA params */

	struct snd_dmaengine_dai_dma_data dma_params_tx;
@@ -1587,6 +1589,8 @@ static int fsl_ssi_suspend(struct device *dev) 


	regmap_read(regs, CCSR_SSI_SFCSR,

			&ssi_private->regcache_sfcsr);

	regmap_read(regs, CCSR_SSI_SACNT,

			&ssi_private->regcache_sacnt);



	regcache_cache_only(regs, true);

	regcache_mark_dirty(regs);
@@ -1605,6 +1609,8 @@ static int fsl_ssi_resume(struct device *dev) 
			CCSR_SSI_SFCSR_RFWM1_MASK | CCSR_SSI_SFCSR_TFWM1_MASK |

			CCSR_SSI_SFCSR_RFWM0_MASK | CCSR_SSI_SFCSR_TFWM0_MASK,

			ssi_private->regcache_sfcsr);

	regmap_write(regs, CCSR_SSI_SACNT,

			ssi_private->regcache_sacnt);



	return regcache_sync(regs);

}