Commit 3ef76759 authored Mar 13, 2012 by Jean Delvare Committed by Mauro Carvalho Chehab Mar 19, 2012

[media] dib0700: Drop useless check when remote key is pressed



struct dvb_usb_device *d can never be NULL so don't waste time
checking for this.

Rationale: the urb's context is set when usb_fill_bulk_urb() is called
in dib0700_rc_setup(), and never changes after that. d is dereferenced
unconditionally in dib0700_rc_setup() so it can't be NULL or the
driver would crash right away.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Devin Heitmueller <dheitmueller@kernellabs.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

parent 401a582f

drivers/media/dvb/dvb-usb/dib0700_core.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -677,9 +677,6 @@ static void dib0700_rc_urb_completion(struct urb *purb)
		u8 toggle;

		deb_info("%s()\n", __func__);
		if (d == NULL)
		return;

		if (d->rc_dev == NULL) {
		/* This will occur if disable_rc_polling=1 */
		usb_free_urb(purb);