Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3e7e8c18 authored by Wei Yongjun's avatar Wei Yongjun Committed by Chris Ball
Browse files

mmc: jz4740: fix return value check in jz4740_mmc_probe() 



In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR(). Also there is already a error message within
devm_ioremap_resource(), so remove the dev_err call to avoid redundant
error message.

Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarChris Ball <cjb@laptop.org>
parent 37c955a7

drivers/mmc/host/jz4740_mmc.c

+2 −3
Original line number Diff line number Diff line
@@ -783,9 +783,8 @@ static int jz4740_mmc_probe(struct platform_device* pdev) 


	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	host->base = devm_ioremap_resource(&pdev->dev, res);

	if (!host->base) {

		ret = -EBUSY;

		dev_err(&pdev->dev, "Failed to ioremap base memory\n");

	if (IS_ERR(host->base)) {

		ret = PTR_ERR(host->base);

		goto err_free_host;

	}