Commit 3e2f69fd authored Jul 01, 2008 by Johannes Weiner Committed by Ingo Molnar Jul 01, 2008

softlockup: fix watchdog task wakeup frequency



The print_timestamp can never be bigger than the touch_timestamp, at
maximum it can be equal.  And if it is, the second check for
touch_timestamp + 1 bigger print_timestamp is always true, too.

The check for equality is sufficient as we proceed in one-second-steps
and are at least one second away from the last print-out if we have
another timestamp.

Signed-off-by: Johannes Weiner <hannes@saeurebad.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent dd7a1e56

kernel/softlockup.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -116,11 +116,8 @@ void softlockup_tick(void)
		print_timestamp = per_cpu(print_timestamp, this_cpu);

		/* report at most once a second */
		if ((print_timestamp >= touch_timestamp &&
		print_timestamp < (touch_timestamp + 1)) \|\|
		did_panic) {
		if (print_timestamp == touch_timestamp \|\| did_panic)
		return;
		}

		/* do not print during early bootup: */
		if (unlikely(system_state != SYSTEM_RUNNING)) {