Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3dba95df authored by Julia Lawall's avatar Julia Lawall Committed by Guenter Roeck
Browse files

hwmon: (lm92) use permission-specific DEVICE_ATTR variants 



Use DEVICE_ATTR_RO for read-only attributes. This simplifies the source
code, improves readbility, and reduces the chance of inconsistencies.

The conversion was done automatically using coccinelle. It was validated
by compiling both the old and the new source code and comparing its text,
data, and bss size.

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
[groeck: Update description]
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 07a366cc

drivers/hwmon/lm92.c

+5 −5
Original line number Diff line number Diff line
@@ -181,7 +181,7 @@ static ssize_t show_temp_hyst(struct device *dev, 
		       - TEMP_FROM_REG(data->temp[t_hyst]));

}



static ssize_t show_temp_min_hyst(struct device *dev,

static ssize_t temp1_min_hyst_show(struct device *dev,

				   struct device_attribute *attr, char *buf)

{

	struct lm92_data *data = lm92_update_device(dev);
@@ -213,7 +213,7 @@ static ssize_t set_temp_hyst(struct device *dev, 
	return count;

}



static ssize_t show_alarms(struct device *dev, struct device_attribute *attr,

static ssize_t alarms_show(struct device *dev, struct device_attribute *attr,

			   char *buf)

{

	struct lm92_data *data = lm92_update_device(dev);
@@ -235,11 +235,11 @@ static SENSOR_DEVICE_ATTR(temp1_crit_hyst, S_IWUSR | S_IRUGO, show_temp_hyst, 
			  set_temp_hyst, t_crit);

static SENSOR_DEVICE_ATTR(temp1_min, S_IWUSR | S_IRUGO, show_temp, set_temp,

			  t_min);

static DEVICE_ATTR(temp1_min_hyst, S_IRUGO, show_temp_min_hyst, NULL);

static DEVICE_ATTR_RO(temp1_min_hyst);

static SENSOR_DEVICE_ATTR(temp1_max, S_IWUSR | S_IRUGO, show_temp, set_temp,

			  t_max);

static SENSOR_DEVICE_ATTR(temp1_max_hyst, S_IRUGO, show_temp_hyst, NULL, t_max);

static DEVICE_ATTR(alarms, S_IRUGO, show_alarms, NULL);

static DEVICE_ATTR_RO(alarms);

static SENSOR_DEVICE_ATTR(temp1_crit_alarm, S_IRUGO, show_alarm, NULL, 2);

static SENSOR_DEVICE_ATTR(temp1_min_alarm, S_IRUGO, show_alarm, NULL, 0);

static SENSOR_DEVICE_ATTR(temp1_max_alarm, S_IRUGO, show_alarm, NULL, 1);