Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3da6c2f3 authored by Stefan Christ's avatar Stefan Christ Committed by Daniel Vetter
Browse files

drm/gma500: use DRM_FB_HELPER_DEFAULT_OPS for fb_ops 



This refactoring leads to real functional changes in the driver.

Now the struct psbfb_ops implements two additional members:

       .fb_setcmap     = drm_fb_helper_setcmap,
       .fb_pan_display = drm_fb_helper_pan_display,

and the struct psbfb_roll_ops implements one additional member:

       .fb_setcmap     = drm_fb_helper_setcmap,

and the struct psbfb_unaccel_ops implements two additional members:

       .fb_setcmap     = drm_fb_helper_setcmap,
       .fb_pan_display = drm_fb_helper_pan_display,

These changes are not tested.

Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Signed-off-by: default avatarStefan Christ <contact@stefanchrist.eu>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1479078208-25221-19-git-send-email-contact@stefanchrist.eu
parent a36384dd

drivers/gpu/drm/gma500/framebuffer.c

+3 −9
Original line number Diff line number Diff line
@@ -185,9 +185,7 @@ static int psbfb_mmap(struct fb_info *info, struct vm_area_struct *vma) 


static struct fb_ops psbfb_ops = {

	.owner = THIS_MODULE,

	.fb_check_var = drm_fb_helper_check_var,

	.fb_set_par = drm_fb_helper_set_par,

	.fb_blank = drm_fb_helper_blank,

	DRM_FB_HELPER_DEFAULT_OPS,

	.fb_setcolreg = psbfb_setcolreg,

	.fb_fillrect = drm_fb_helper_cfb_fillrect,

	.fb_copyarea = psbfb_copyarea,
@@ -198,9 +196,7 @@ static struct fb_ops psbfb_ops = { 


static struct fb_ops psbfb_roll_ops = {

	.owner = THIS_MODULE,

	.fb_check_var = drm_fb_helper_check_var,

	.fb_set_par = drm_fb_helper_set_par,

	.fb_blank = drm_fb_helper_blank,

	DRM_FB_HELPER_DEFAULT_OPS,

	.fb_setcolreg = psbfb_setcolreg,

	.fb_fillrect = drm_fb_helper_cfb_fillrect,

	.fb_copyarea = drm_fb_helper_cfb_copyarea,
@@ -211,9 +207,7 @@ static struct fb_ops psbfb_roll_ops = { 


static struct fb_ops psbfb_unaccel_ops = {

	.owner = THIS_MODULE,

	.fb_check_var = drm_fb_helper_check_var,

	.fb_set_par = drm_fb_helper_set_par,

	.fb_blank = drm_fb_helper_blank,

	DRM_FB_HELPER_DEFAULT_OPS,

	.fb_setcolreg = psbfb_setcolreg,

	.fb_fillrect = drm_fb_helper_cfb_fillrect,

	.fb_copyarea = drm_fb_helper_cfb_copyarea,