Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3d784273 authored by Wenyou Yang's avatar Wenyou Yang Committed by Linus Walleij
Browse files

pinctrl: at91: disable PD or PU before enabling PU or PD 



Disable Pull-Down or Pull-Up property before enabling Pull-Up or
Pull-Down, because the pin's Pull-Up and Pull-Down property is
mutually exclusive.

Signed-off-by: default avatarWenyou Yang <wenyou.yang@atmel.com>
Acked-by: default avatarNicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 7471725f

drivers/pinctrl/pinctrl-at91.c

+6 −0
Original line number Diff line number Diff line
@@ -371,6 +371,9 @@ static unsigned at91_mux_get_pullup(void __iomem *pio, unsigned pin) 


static void at91_mux_set_pullup(void __iomem *pio, unsigned mask, bool on)

{

	if (on)

		writel_relaxed(mask, pio + PIO_PPDDR);



	writel_relaxed(mask, pio + (on ? PIO_PUER : PIO_PUDR));

}
@@ -499,6 +502,9 @@ static bool at91_mux_pio3_get_pulldown(void __iomem *pio, unsigned pin) 


static void at91_mux_pio3_set_pulldown(void __iomem *pio, unsigned mask, bool is_on)

{

	if (is_on)

		__raw_writel(mask, pio + PIO_PUDR);



	__raw_writel(mask, pio + (is_on ? PIO_PPDER : PIO_PPDDR));

}