Commit 3bacb36d authored Dec 10, 2006 by Akinobu Mita Committed by Jean Delvare Dec 10, 2006

i2c: Fix return value check in i2c-dev



device_create() returns error code as pointer on failures.
This patch checks the return value of device_create() by using IS_ERR().

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Jean Delvare <khali@linux-fr.org>

parent 250d1bd3

drivers/i2c/i2c-dev.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -416,8 +416,8 @@ static int i2cdev_attach_adapter(struct i2c_adapter *adap)
		i2c_dev->dev = device_create(i2c_dev_class, &adap->dev,
		MKDEV(I2C_MAJOR, adap->nr),
		"i2c-%d", adap->nr);
		if (!i2c_dev->dev) {
		res = -ENODEV;
		if (IS_ERR(i2c_dev->dev)) {
		res = PTR_ERR(i2c_dev->dev);
		goto error;
		}
		res = device_create_file(i2c_dev->dev, &dev_attr_name);