Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3b51096f authored by Alexey Dobriyan's avatar Alexey Dobriyan Committed by Dave Airlie
Browse files

drm: use proc_create_data() 



airlied: fixup race against drm info by filling out
tmp before adding it to proc.

Signed-off-by: default avatarAlexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent 882f0219

drivers/gpu/drm/drm_proc.c

+7 −6
Original line number Diff line number Diff line
@@ -110,20 +110,21 @@ int drm_proc_create_files(struct drm_info_list *files, int count, 
			ret = -1;

			goto fail;

		}

		ent = create_proc_entry(files[i].name, S_IFREG | S_IRUGO, root);

		tmp->minor = minor;

		tmp->info_ent = &files[i];

		list_add(&tmp->list, &minor->proc_nodes.list);



		ent = proc_create_data(files[i].name, S_IRUGO, root,

				       &drm_proc_fops, tmp);

		if (!ent) {

			DRM_ERROR("Cannot create /proc/dri/%s/%s\n",

				  name, files[i].name);

			list_del(&tmp->list);

			kfree(tmp);

			ret = -1;

			goto fail;

		}



		ent->proc_fops = &drm_proc_fops;

		ent->data = tmp;

		tmp->minor = minor;

		tmp->info_ent = &files[i];

		list_add(&(tmp->list), &(minor->proc_nodes.list));

	}

	return 0;