Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3a8ed20d authored by Tony Lindgren's avatar Tony Lindgren
Browse files

ARM: dts: Disable HDMI CEC internal pull-ups 



Devices using an external encoder, ESD protection and level shifter
such as tpd12s015 or ip4791cz12 have the CEC pull in the encoder
chip. And on var-som-om44, there is external pull up resistor R30.

So the internal CEC pull-up resistor needs to be disabled as otherwise
the external and internal pull are parallel making the pull value
much smaller than intended. This leads into the CEC not working as
reported by Hans Verkuil <hverkuil@xs4all.nl>.

Reported-by: default avatarHans Verkuil <hverkuil@xs4all.nl>
Cc: Dmitry Lifshitz <lifshitz@compulab.co.il>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
parent 092976ed

arch/arm/boot/dts/omap4-droid4-xt894.dts

+1 −1
Original line number Diff line number Diff line
@@ -373,7 +373,7 @@ 
	/* hdmi_cec.hdmi_cec, hdmi_scl.hdmi_scl, hdmi_sda.hdmi_sda */

	dss_hdmi_pins: pinmux_dss_hdmi_pins {

		pinctrl-single,pins = <

		OMAP4_IOPAD(0x09a, PIN_INPUT_PULLUP | MUX_MODE0)

		OMAP4_IOPAD(0x09a, PIN_INPUT | MUX_MODE0)

		OMAP4_IOPAD(0x09c, PIN_INPUT | MUX_MODE0)

		OMAP4_IOPAD(0x09e, PIN_INPUT | MUX_MODE0)

		>;

arch/arm/boot/dts/omap4-duovero-parlor.dts

+1 −1
Original line number Diff line number Diff line
@@ -100,7 +100,7 @@ 
	dss_hdmi_pins: pinmux_dss_hdmi_pins {

		pinctrl-single,pins = <

			OMAP4_IOPAD(0x098, PIN_INPUT | MUX_MODE3)		/* hdmi_hpd.gpio_63 */

			OMAP4_IOPAD(0x09a, PIN_INPUT_PULLUP | MUX_MODE0)	/* hdmi_cec.hdmi_cec */

			OMAP4_IOPAD(0x09a, PIN_INPUT | MUX_MODE0)		/* hdmi_cec.hdmi_cec */

			OMAP4_IOPAD(0x09c, PIN_INPUT_PULLUP | MUX_MODE0)	/* hdmi_ddc_scl.hdmi_ddc_scl */

			OMAP4_IOPAD(0x09e, PIN_INPUT_PULLUP | MUX_MODE0)	/* hdmi_ddc_sda.hdmi_ddc_sda */

		>;

arch/arm/boot/dts/omap4-panda-common.dtsi

+1 −1
Original line number Diff line number Diff line
@@ -267,7 +267,7 @@ 


	dss_hdmi_pins: pinmux_dss_hdmi_pins {

		pinctrl-single,pins = <

			OMAP4_IOPAD(0x09a, PIN_INPUT_PULLUP | MUX_MODE0)	/* hdmi_cec.hdmi_cec */

			OMAP4_IOPAD(0x09a, PIN_INPUT | MUX_MODE0)		/* hdmi_cec.hdmi_cec */

			OMAP4_IOPAD(0x09c, PIN_INPUT_PULLUP | MUX_MODE0)	/* hdmi_scl.hdmi_scl */

			OMAP4_IOPAD(0x09e, PIN_INPUT_PULLUP | MUX_MODE0)	/* hdmi_sda.hdmi_sda */

		>;

arch/arm/boot/dts/omap4-sdp-es23plus.dts

+1 −1
Original line number Diff line number Diff line
@@ -10,7 +10,7 @@ 
/* SDP boards with 4430 ES2.3+ or 4460 have external pullups on SCL & SDA */

&dss_hdmi_pins {

	pinctrl-single,pins = <

		OMAP4_IOPAD(0x09a, PIN_INPUT_PULLUP | MUX_MODE0)	/* hdmi_cec.hdmi_cec */

		OMAP4_IOPAD(0x09a, PIN_INPUT | MUX_MODE0)		/* hdmi_cec.hdmi_cec */

		OMAP4_IOPAD(0x09c, PIN_INPUT | MUX_MODE0)		/* hdmi_scl.hdmi_scl */

		OMAP4_IOPAD(0x09e, PIN_INPUT | MUX_MODE0)		/* hdmi_sda.hdmi_sda */

		>;

arch/arm/boot/dts/omap4-sdp.dts

+1 −1
Original line number Diff line number Diff line
@@ -290,7 +290,7 @@ 


	dss_hdmi_pins: pinmux_dss_hdmi_pins {

		pinctrl-single,pins = <

			OMAP4_IOPAD(0x09a, PIN_INPUT_PULLUP | MUX_MODE0)	/* hdmi_cec.hdmi_cec */

			OMAP4_IOPAD(0x09a, PIN_INPUT | MUX_MODE0)		/* hdmi_cec.hdmi_cec */

			OMAP4_IOPAD(0x09c, PIN_INPUT_PULLUP | MUX_MODE0)	/* hdmi_scl.hdmi_scl */

			OMAP4_IOPAD(0x09e, PIN_INPUT_PULLUP | MUX_MODE0)	/* hdmi_sda.hdmi_sda */

		>;