Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 39dcf4f7 authored by Fabio Estevam's avatar Fabio Estevam Committed by Greg Kroah-Hartman
Browse files

imx-drm: parallel-display: Check 'mode' pointer first 



Fix the following static checker warnings:

drivers/staging/imx-drm/parallel-display.c:64 imx_pd_connector_get_modes() error: potential null dereference 'mode'.  (drm_mode_create returns null)
drivers/staging/imx-drm/parallel-display.c:73 imx_pd_connector_get_modes() error: potential null dereference 'mode'.  (drm_mode_create returns null)

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarFabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9f9b036f

drivers/staging/imx-drm/parallel-display.c

+4 −0
Original line number Diff line number Diff line
@@ -70,6 +70,8 @@ static int imx_pd_connector_get_modes(struct drm_connector *connector) 


	if (imxpd->mode_valid) {

		struct drm_display_mode *mode = drm_mode_create(connector->dev);

		if (!mode)

			return -EINVAL;

		drm_mode_copy(mode, &imxpd->mode);

		mode->type |= DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED,

		drm_mode_probed_add(connector, mode);
@@ -78,6 +80,8 @@ static int imx_pd_connector_get_modes(struct drm_connector *connector) 


	if (np) {

		struct drm_display_mode *mode = drm_mode_create(connector->dev);

		if (!mode)

			return -EINVAL;

		of_get_drm_display_mode(np, &imxpd->mode, OF_USE_NATIVE_MODE);

		drm_mode_copy(mode, &imxpd->mode);

		mode->type |= DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED,