Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3940ee36 authored by Linus Torvalds's avatar Linus Torvalds
Browse files
Pull orangefs updates from Mike Marshall:
 "Miscellaneous improvements:
   - clean up debugfs globals
   - remove dead code in sysfs
   - reorganize duplicated sysfs attribute structs
   - consolidate sysfs show and store functions
   - remove duplicated sysfs_ops structures
   - describe organization of sysfs
   - make devreq_mutex static
   - g_orangefs_stats -> orangefs_stats for consistency
   - rename most remaining global variables

  Feature negotiation:
   - enable Orangefs userspace and kernel module to negotiate mutually
     supported features"

* tag 'for-linus-4.9-ofs1' of git://git.kernel.org/pub/scm/linux/kernel/git/hubcap/linux:
  Revert "orangefs: bump minimum userspace version"
  orangefs: bump minimum userspace version
  orangefs: rename most remaining global variables
  orangefs: g_orangefs_stats -> orangefs_stats for consistency
  orangefs: make devreq_mutex static
  orangefs: describe organization of sysfs
  orangefs: remove duplicated sysfs_ops structures
  orangefs: consolidate sysfs show and store functions
  orangefs: reorganize duplicated sysfs attribute structs
  orangefs: remove dead code in sysfs
  orangefs: clean up debugfs globals
  orangefs: do not allow client readahead cache without feature bit
  orangefs: add features op
  orangefs: record userspace version for feature compatbility
  orangefs: add readahead count and size to sysfs
  orangefs: re-add flush_racache from out-of-tree
  orangefs: turn param response value into union
  orangefs: add missing param request ops
  orangefs: rename remaining bits of mmap readahead cache
parents 95107b30 f60fbdbf
Loading
Loading
Loading
Loading
+1 −1
Original line number Original line Diff line number Diff line
@@ -73,7 +73,7 @@ static int orangefs_revalidate_lookup(struct dentry *dentry)
		}
		}
	}
	}


	dentry->d_time = jiffies + dcache_timeout_msecs*HZ/1000;
	dentry->d_time = jiffies + orangefs_dcache_timeout_msecs*HZ/1000;
	ret = 1;
	ret = 1;
out_release_op:
out_release_op:
	op_release(new_op);
	op_release(new_op);
+26 −138
Original line number Original line Diff line number Diff line
@@ -11,14 +11,19 @@
#include "orangefs-kernel.h"
#include "orangefs-kernel.h"
#include "orangefs-dev-proto.h"
#include "orangefs-dev-proto.h"
#include "orangefs-bufmap.h"
#include "orangefs-bufmap.h"
#include "orangefs-debugfs.h"


#include <linux/debugfs.h>
#include <linux/debugfs.h>
#include <linux/slab.h>
#include <linux/slab.h>


/* this file implements the /dev/pvfs2-req device node */
/* this file implements the /dev/pvfs2-req device node */


uint32_t orangefs_userspace_version;

static int open_access_count;
static int open_access_count;


static DEFINE_MUTEX(devreq_mutex);

#define DUMP_DEVICE_ERROR()                                                   \
#define DUMP_DEVICE_ERROR()                                                   \
do {                                                                          \
do {                                                                          \
	gossip_err("*****************************************************\n");\
	gossip_err("*****************************************************\n");\
@@ -43,7 +48,7 @@ static void orangefs_devreq_add_op(struct orangefs_kernel_op_s *op)
{
{
	int index = hash_func(op->tag, hash_table_size);
	int index = hash_func(op->tag, hash_table_size);


	list_add_tail(&op->list, &htable_ops_in_progress[index]);
	list_add_tail(&op->list, &orangefs_htable_ops_in_progress[index]);
}
}


/*
/*
@@ -57,20 +62,20 @@ static struct orangefs_kernel_op_s *orangefs_devreq_remove_op(__u64 tag)


	index = hash_func(tag, hash_table_size);
	index = hash_func(tag, hash_table_size);


	spin_lock(&htable_ops_in_progress_lock);
	spin_lock(&orangefs_htable_ops_in_progress_lock);
	list_for_each_entry_safe(op,
	list_for_each_entry_safe(op,
				 next,
				 next,
				 &htable_ops_in_progress[index],
				 &orangefs_htable_ops_in_progress[index],
				 list) {
				 list) {
		if (op->tag == tag && !op_state_purged(op) &&
		if (op->tag == tag && !op_state_purged(op) &&
		    !op_state_given_up(op)) {
		    !op_state_given_up(op)) {
			list_del_init(&op->list);
			list_del_init(&op->list);
			spin_unlock(&htable_ops_in_progress_lock);
			spin_unlock(&orangefs_htable_ops_in_progress_lock);
			return op;
			return op;
		}
		}
	}
	}


	spin_unlock(&htable_ops_in_progress_lock);
	spin_unlock(&orangefs_htable_ops_in_progress_lock);
	return NULL;
	return NULL;
}
}


@@ -276,11 +281,11 @@ static ssize_t orangefs_devreq_read(struct file *file,
	if (ret != 0)
	if (ret != 0)
		goto error;
		goto error;


	spin_lock(&htable_ops_in_progress_lock);
	spin_lock(&orangefs_htable_ops_in_progress_lock);
	spin_lock(&cur_op->lock);
	spin_lock(&cur_op->lock);
	if (unlikely(op_state_given_up(cur_op))) {
	if (unlikely(op_state_given_up(cur_op))) {
		spin_unlock(&cur_op->lock);
		spin_unlock(&cur_op->lock);
		spin_unlock(&htable_ops_in_progress_lock);
		spin_unlock(&orangefs_htable_ops_in_progress_lock);
		complete(&cur_op->waitq);
		complete(&cur_op->waitq);
		goto restart;
		goto restart;
	}
	}
@@ -298,7 +303,7 @@ static ssize_t orangefs_devreq_read(struct file *file,
		     current->comm);
		     current->comm);
	orangefs_devreq_add_op(cur_op);
	orangefs_devreq_add_op(cur_op);
	spin_unlock(&cur_op->lock);
	spin_unlock(&cur_op->lock);
	spin_unlock(&htable_ops_in_progress_lock);
	spin_unlock(&orangefs_htable_ops_in_progress_lock);


	/* The client only asks to read one size buffer. */
	/* The client only asks to read one size buffer. */
	return MAX_DEV_REQ_UPSIZE;
	return MAX_DEV_REQ_UPSIZE;
@@ -387,6 +392,13 @@ static ssize_t orangefs_devreq_write_iter(struct kiocb *iocb,
		return -EPROTO;
		return -EPROTO;
	}
	}


	if (!orangefs_userspace_version) {
		orangefs_userspace_version = head.version;
	} else if (orangefs_userspace_version != head.version) {
		gossip_err("Error: userspace version changes\n");
		return -EPROTO;
	}

	/* remove the op from the in progress hash table */
	/* remove the op from the in progress hash table */
	op = orangefs_devreq_remove_op(head.tag);
	op = orangefs_devreq_remove_op(head.tag);
	if (!op) {
	if (!op) {
@@ -527,6 +539,7 @@ static int orangefs_devreq_release(struct inode *inode, struct file *file)
	gossip_debug(GOSSIP_DEV_DEBUG,
	gossip_debug(GOSSIP_DEV_DEBUG,
		     "pvfs2-client-core: device close complete\n");
		     "pvfs2-client-core: device close complete\n");
	open_access_count = 0;
	open_access_count = 0;
	orangefs_userspace_version = 0;
	mutex_unlock(&devreq_mutex);
	mutex_unlock(&devreq_mutex);
	return 0;
	return 0;
}
}
@@ -576,8 +589,6 @@ static long dispatch_ioctl_command(unsigned int command, unsigned long arg)
	static __s32 max_down_size = MAX_DEV_REQ_DOWNSIZE;
	static __s32 max_down_size = MAX_DEV_REQ_DOWNSIZE;
	struct ORANGEFS_dev_map_desc user_desc;
	struct ORANGEFS_dev_map_desc user_desc;
	int ret = 0;
	int ret = 0;
	struct dev_mask_info_s mask_info = { 0 };
	struct dev_mask2_info_s mask2_info = { 0, 0 };
	int upstream_kmod = 1;
	int upstream_kmod = 1;
	struct orangefs_sb_info_s *orangefs_sb;
	struct orangefs_sb_info_s *orangefs_sb;


@@ -619,7 +630,7 @@ static long dispatch_ioctl_command(unsigned int command, unsigned long arg)
		 * all of the remounts are serviced (to avoid ops between
		 * all of the remounts are serviced (to avoid ops between
		 * mounts to fail)
		 * mounts to fail)
		 */
		 */
		ret = mutex_lock_interruptible(&request_mutex);
		ret = mutex_lock_interruptible(&orangefs_request_mutex);
		if (ret < 0)
		if (ret < 0)
			return ret;
			return ret;
		gossip_debug(GOSSIP_DEV_DEBUG,
		gossip_debug(GOSSIP_DEV_DEBUG,
@@ -654,7 +665,7 @@ static long dispatch_ioctl_command(unsigned int command, unsigned long arg)
		gossip_debug(GOSSIP_DEV_DEBUG,
		gossip_debug(GOSSIP_DEV_DEBUG,
			     "%s: priority remount complete\n",
			     "%s: priority remount complete\n",
			     __func__);
			     __func__);
		mutex_unlock(&request_mutex);
		mutex_unlock(&orangefs_request_mutex);
		return ret;
		return ret;


	case ORANGEFS_DEV_UPSTREAM:
	case ORANGEFS_DEV_UPSTREAM:
@@ -668,134 +679,11 @@ static long dispatch_ioctl_command(unsigned int command, unsigned long arg)
			return ret;
			return ret;


	case ORANGEFS_DEV_CLIENT_MASK:
	case ORANGEFS_DEV_CLIENT_MASK:
		ret = copy_from_user(&mask2_info,
		return orangefs_debugfs_new_client_mask((void __user *)arg);
				     (void __user *)arg,
				     sizeof(struct dev_mask2_info_s));

		if (ret != 0)
			return -EIO;

		client_debug_mask.mask1 = mask2_info.mask1_value;
		client_debug_mask.mask2 = mask2_info.mask2_value;

		pr_info("%s: client debug mask has been been received "
			":%llx: :%llx:\n",
			__func__,
			(unsigned long long)client_debug_mask.mask1,
			(unsigned long long)client_debug_mask.mask2);

		return ret;

	case ORANGEFS_DEV_CLIENT_STRING:
	case ORANGEFS_DEV_CLIENT_STRING:
		ret = copy_from_user(&client_debug_array_string,
		return orangefs_debugfs_new_client_string((void __user *)arg);
				     (void __user *)arg,
				     ORANGEFS_MAX_DEBUG_STRING_LEN);
		/*
		 * The real client-core makes an effort to ensure
		 * that actual strings that aren't too long to fit in
		 * this buffer is what we get here. We're going to use
		 * string functions on the stuff we got, so we'll make
		 * this extra effort to try and keep from
		 * flowing out of this buffer when we use the string
		 * functions, even if somehow the stuff we end up
		 * with here is garbage.
		 */
		client_debug_array_string[ORANGEFS_MAX_DEBUG_STRING_LEN - 1] =
			'\0';
		
		if (ret != 0) {
			pr_info("%s: CLIENT_STRING: copy_from_user failed\n",
				__func__);
			return -EIO;
		}

		pr_info("%s: client debug array string has been received.\n",
			__func__);

		if (!help_string_initialized) {

			/* Free the "we don't know yet" default string... */
			kfree(debug_help_string);

			/* build a proper debug help string */
			if (orangefs_prepare_debugfs_help_string(0)) {
				gossip_err("%s: no debug help string \n",
					   __func__);
				return -EIO;
			}

			/* Replace the boilerplate boot-time debug-help file. */
			debugfs_remove(help_file_dentry);

			help_file_dentry =
				debugfs_create_file(
					ORANGEFS_KMOD_DEBUG_HELP_FILE,
					0444,
					debug_dir,
					debug_help_string,
					&debug_help_fops);

			if (!help_file_dentry) {
				gossip_err("%s: debugfs_create_file failed for"
					   " :%s:!\n",
					   __func__,
					   ORANGEFS_KMOD_DEBUG_HELP_FILE);
				return -EIO;
			}
		}

		debug_mask_to_string(&client_debug_mask, 1);

		debugfs_remove(client_debug_dentry);

		orangefs_client_debug_init();

		help_string_initialized++;

		return ret;

	case ORANGEFS_DEV_DEBUG:
	case ORANGEFS_DEV_DEBUG:
		ret = copy_from_user(&mask_info,
		return orangefs_debugfs_new_debug((void __user *)arg);
				     (void __user *)arg,
				     sizeof(mask_info));

		if (ret != 0)
			return -EIO;

		if (mask_info.mask_type == KERNEL_MASK) {
			if ((mask_info.mask_value == 0)
			    && (kernel_mask_set_mod_init)) {
				/*
				 * the kernel debug mask was set when the
				 * kernel module was loaded; don't override
				 * it if the client-core was started without
				 * a value for ORANGEFS_KMODMASK.
				 */
				return 0;
			}
			debug_mask_to_string(&mask_info.mask_value,
					     mask_info.mask_type);
			gossip_debug_mask = mask_info.mask_value;
			pr_info("%s: kernel debug mask has been modified to "
				":%s: :%llx:\n",
				__func__,
				kernel_debug_string,
				(unsigned long long)gossip_debug_mask);
		} else if (mask_info.mask_type == CLIENT_MASK) {
			debug_mask_to_string(&mask_info.mask_value,
					     mask_info.mask_type);
			pr_info("%s: client debug mask has been modified to"
				":%s: :%llx:\n",
				__func__,
				client_debug_string,
				llu(mask_info.mask_value));
		} else {
			gossip_lerr("Invalid mask type....\n");
			return -EINVAL;
		}

		return ret;

	default:
	default:
		return -ENOIOCTLCMD;
		return -ENOIOCTLCMD;
	}
	}
+10 −1
Original line number Original line Diff line number Diff line
@@ -83,7 +83,10 @@ struct orangefs_listxattr_response {
};
};


struct orangefs_param_response {
struct orangefs_param_response {
	__s64 value;
	union {
		__s64 value64;
		__s32 value32[2];
	} u;
};
};


#define PERF_COUNT_BUF_SIZE 4096
#define PERF_COUNT_BUF_SIZE 4096
@@ -98,6 +101,11 @@ struct orangefs_fs_key_response {
	char fs_key[FS_KEY_BUF_SIZE];
	char fs_key[FS_KEY_BUF_SIZE];
};
};


/* 2.9.6 */
struct orangefs_features_response {
	__u64 features;
};

struct orangefs_downcall_s {
struct orangefs_downcall_s {
	__s32 type;
	__s32 type;
	__s32 status;
	__s32 status;
@@ -119,6 +127,7 @@ struct orangefs_downcall_s {
		struct orangefs_param_response param;
		struct orangefs_param_response param;
		struct orangefs_perf_count_response perf_count;
		struct orangefs_perf_count_response perf_count;
		struct orangefs_fs_key_response fs_key;
		struct orangefs_fs_key_response fs_key;
		struct orangefs_features_response features;
	} resp;
	} resp;
};
};


+40 −5
Original line number Original line Diff line number Diff line
@@ -14,6 +14,32 @@
#include <linux/fs.h>
#include <linux/fs.h>
#include <linux/pagemap.h>
#include <linux/pagemap.h>


static int flush_racache(struct inode *inode)
{
	struct orangefs_inode_s *orangefs_inode = ORANGEFS_I(inode);
	struct orangefs_kernel_op_s *new_op;
	int ret;

	gossip_debug(GOSSIP_UTILS_DEBUG,
	    "%s: %pU: Handle is %pU | fs_id %d\n", __func__,
	    get_khandle_from_ino(inode), &orangefs_inode->refn.khandle,
	    orangefs_inode->refn.fs_id);

	new_op = op_alloc(ORANGEFS_VFS_OP_RA_FLUSH);
	if (!new_op)
		return -ENOMEM;
	new_op->upcall.req.ra_cache_flush.refn = orangefs_inode->refn;

	ret = service_operation(new_op, "orangefs_flush_racache",
	    get_interruptible_flag(inode));

	gossip_debug(GOSSIP_UTILS_DEBUG, "%s: got return value of %d\n",
	    __func__, ret);

	op_release(new_op);
	return ret;
}

/*
/*
 * Copy to client-core's address space from the buffers specified
 * Copy to client-core's address space from the buffers specified
 * by the iovec upto total_size bytes.
 * by the iovec upto total_size bytes.
@@ -386,7 +412,7 @@ ssize_t orangefs_inode_read(struct inode *inode,
	size_t bufmap_size;
	size_t bufmap_size;
	ssize_t ret = -EINVAL;
	ssize_t ret = -EINVAL;


	g_orangefs_stats.reads++;
	orangefs_stats.reads++;


	bufmap_size = orangefs_bufmap_size_query();
	bufmap_size = orangefs_bufmap_size_query();
	if (count > bufmap_size) {
	if (count > bufmap_size) {
@@ -427,7 +453,7 @@ static ssize_t orangefs_file_read_iter(struct kiocb *iocb, struct iov_iter *iter


	gossip_debug(GOSSIP_FILE_DEBUG, "orangefs_file_read_iter\n");
	gossip_debug(GOSSIP_FILE_DEBUG, "orangefs_file_read_iter\n");


	g_orangefs_stats.reads++;
	orangefs_stats.reads++;


	rc = do_readv_writev(ORANGEFS_IO_READ, file, &pos, iter);
	rc = do_readv_writev(ORANGEFS_IO_READ, file, &pos, iter);
	iocb->ki_pos = pos;
	iocb->ki_pos = pos;
@@ -488,7 +514,7 @@ static ssize_t orangefs_file_write_iter(struct kiocb *iocb, struct iov_iter *ite
	}
	}


	iocb->ki_pos = pos;
	iocb->ki_pos = pos;
	g_orangefs_stats.writes++;
	orangefs_stats.writes++;


out:
out:


@@ -591,15 +617,24 @@ static int orangefs_file_release(struct inode *inode, struct file *file)
	orangefs_flush_inode(inode);
	orangefs_flush_inode(inode);


	/*
	/*
	 * remove all associated inode pages from the page cache and mmap
	 * remove all associated inode pages from the page cache and
	 * readahead cache (if any); this forces an expensive refresh of
	 * readahead cache (if any); this forces an expensive refresh of
	 * data for the next caller of mmap (or 'get_block' accesses)
	 * data for the next caller of mmap (or 'get_block' accesses)
	 */
	 */
	if (file->f_path.dentry->d_inode &&
	if (file->f_path.dentry->d_inode &&
	    file->f_path.dentry->d_inode->i_mapping &&
	    file->f_path.dentry->d_inode->i_mapping &&
	    mapping_nrpages(&file->f_path.dentry->d_inode->i_data))
	    mapping_nrpages(&file->f_path.dentry->d_inode->i_data)) {
		if (orangefs_features & ORANGEFS_FEATURE_READAHEAD) {
			gossip_debug(GOSSIP_INODE_DEBUG,
			    "calling flush_racache on %pU\n",
			    get_khandle_from_ino(inode));
			flush_racache(inode);
			gossip_debug(GOSSIP_INODE_DEBUG,
			    "flush_racache finished\n");
		}
		truncate_inode_pages(file->f_path.dentry->d_inode->i_mapping,
		truncate_inode_pages(file->f_path.dentry->d_inode->i_mapping,
				     0);
				     0);
	}
	return 0;
	return 0;
}
}


+4 −4
Original line number Original line Diff line number Diff line
@@ -72,7 +72,7 @@ static int orangefs_create(struct inode *dir,


	d_instantiate(dentry, inode);
	d_instantiate(dentry, inode);
	unlock_new_inode(inode);
	unlock_new_inode(inode);
	dentry->d_time = jiffies + dcache_timeout_msecs*HZ/1000;
	dentry->d_time = jiffies + orangefs_dcache_timeout_msecs*HZ/1000;
	ORANGEFS_I(inode)->getattr_time = jiffies - 1;
	ORANGEFS_I(inode)->getattr_time = jiffies - 1;


	gossip_debug(GOSSIP_NAME_DEBUG,
	gossip_debug(GOSSIP_NAME_DEBUG,
@@ -183,7 +183,7 @@ static struct dentry *orangefs_lookup(struct inode *dir, struct dentry *dentry,
		goto out;
		goto out;
	}
	}


	dentry->d_time = jiffies + dcache_timeout_msecs*HZ/1000;
	dentry->d_time = jiffies + orangefs_dcache_timeout_msecs*HZ/1000;


	inode = orangefs_iget(dir->i_sb, &new_op->downcall.resp.lookup.refn);
	inode = orangefs_iget(dir->i_sb, &new_op->downcall.resp.lookup.refn);
	if (IS_ERR(inode)) {
	if (IS_ERR(inode)) {
@@ -322,7 +322,7 @@ static int orangefs_symlink(struct inode *dir,


	d_instantiate(dentry, inode);
	d_instantiate(dentry, inode);
	unlock_new_inode(inode);
	unlock_new_inode(inode);
	dentry->d_time = jiffies + dcache_timeout_msecs*HZ/1000;
	dentry->d_time = jiffies + orangefs_dcache_timeout_msecs*HZ/1000;
	ORANGEFS_I(inode)->getattr_time = jiffies - 1;
	ORANGEFS_I(inode)->getattr_time = jiffies - 1;


	gossip_debug(GOSSIP_NAME_DEBUG,
	gossip_debug(GOSSIP_NAME_DEBUG,
@@ -386,7 +386,7 @@ static int orangefs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode


	d_instantiate(dentry, inode);
	d_instantiate(dentry, inode);
	unlock_new_inode(inode);
	unlock_new_inode(inode);
	dentry->d_time = jiffies + dcache_timeout_msecs*HZ/1000;
	dentry->d_time = jiffies + orangefs_dcache_timeout_msecs*HZ/1000;
	ORANGEFS_I(inode)->getattr_time = jiffies - 1;
	ORANGEFS_I(inode)->getattr_time = jiffies - 1;


	gossip_debug(GOSSIP_NAME_DEBUG,
	gossip_debug(GOSSIP_NAME_DEBUG,
Loading