Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3909fab5 authored by Lars-Peter Clausen's avatar Lars-Peter Clausen Committed by Jonathan Cameron
Browse files

iio:buffer: Ignore noop requests for iio_update_buffers() 



Since the kernel now disables all buffers when a device is unregistered it might
happen that a in-kernel consumer tries to disable that buffer again. So ignore
requests where the buffer already is in the desired state.

Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
parent ec87197f

drivers/iio/industrialio-buffer.c

+14 −0
Original line number Diff line number Diff line
@@ -664,9 +664,23 @@ int iio_update_buffers(struct iio_dev *indio_dev, 
{

	int ret;



	if (insert_buffer == remove_buffer)

		return 0;



	mutex_lock(&indio_dev->info_exist_lock);

	mutex_lock(&indio_dev->mlock);



	if (insert_buffer && iio_buffer_is_active(insert_buffer))

		insert_buffer = NULL;



	if (remove_buffer && !iio_buffer_is_active(remove_buffer))

		remove_buffer = NULL;



	if (!insert_buffer && !remove_buffer) {

		ret = 0;

		goto out_unlock;

	}



	if (indio_dev->info == NULL) {

		ret = -ENODEV;

		goto out_unlock;