Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 38cfc148 authored by Alessandro Guido's avatar Alessandro Guido Committed by Len Brown
Browse files

sony-laptop: brightness regression fix



After commit 540b8bb9:

  sony-laptop: fingers off backlight if video.ko is serving this functionality

I can't set brightness on my sony laptop (nothing in /sys/class/backlight).
dmesg says "sony-laptop: Sony: Brightness ignored, must be controlled by ACPI
video driver".

The function acpi_video_backlight_support returns 0 if we should use the
vendor-specific backlight support, while non-0 if the ACPI generic should
be used. Because of this, the check introduced by the said commit appears
reversed.

Signed-off-by: default avatarAlessandro Guido <ag@alessandroguido.name>
Signed-off-by: default avatarLen Brown <len.brown@intel.com>
parent 3bdca1b8
Loading
Loading
Loading
Loading
+1 −1
Original line number Original line Diff line number Diff line
@@ -1038,7 +1038,7 @@ static int sony_nc_add(struct acpi_device *device)
		goto outinput;
		goto outinput;
	}
	}


	if (!acpi_video_backlight_support()) {
	if (acpi_video_backlight_support()) {
		printk(KERN_INFO DRV_PFX "Sony: Brightness ignored, must be "
		printk(KERN_INFO DRV_PFX "Sony: Brightness ignored, must be "
		       "controlled by ACPI video driver\n");
		       "controlled by ACPI video driver\n");
	} else if (ACPI_SUCCESS(acpi_get_handle(sony_nc_acpi_handle, "GBRT",
	} else if (ACPI_SUCCESS(acpi_get_handle(sony_nc_acpi_handle, "GBRT",