Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 385e3ed4 authored by Roland Dreier's avatar Roland Dreier Committed by Al Viro
Browse files

alloc_file(): simplify handling of mnt_clone_write() errors 



When alloc_file() and init_file() were combined, the error handling of
mnt_clone_write() was taken into alloc_file() in a somewhat obfuscated
way.  Since we don't use the error code for anything except warning,
we might as well warn directly without an extra variable.

Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent f7b84a6b

fs/file_table.c

+1 −3
Original line number Diff line number Diff line
@@ -186,10 +186,8 @@ struct file *alloc_file(struct path *path, fmode_t mode, 
	 * that we can do debugging checks at __fput()

	 */

	if ((mode & FMODE_WRITE) && !special_file(path->dentry->d_inode->i_mode)) {

		int error = 0;

		file_take_write(file);

		error = mnt_clone_write(path->mnt);

		WARN_ON(error);

		WARN_ON(mnt_clone_write(path->mnt));

	}

	ima_counts_get(file);

	return file;