Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 385a79df authored by Sergio Paracuellos's avatar Sergio Paracuellos Committed by Greg Kroah-Hartman
Browse files

staging: wlang-ng: avoid new typedef: hfa384x_usb_cmdresp_t 



This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_usb_cmdresp_t

Signed-off-by: default avatarSergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e20a7ca1

drivers/staging/wlan-ng/hfa384x.h

+5 −5
Original line number Diff line number Diff line
@@ -865,15 +865,15 @@ struct hfa384x_usb_infofrm { 
	struct hfa384x_InfFrame info;

} __packed;



typedef struct hfa384x_usb_statusresp {

struct hfa384x_usb_statusresp {

	u16 type;

	u16 status;

	u16 resp0;

	u16 resp1;

	u16 resp2;

} __packed hfa384x_usb_cmdresp_t;

} __packed;



typedef hfa384x_usb_cmdresp_t hfa384x_usb_wridresp_t;

typedef struct hfa384x_usb_statusresp hfa384x_usb_wridresp_t;



typedef struct hfa384x_usb_rridresp {

	u16 type;
@@ -882,7 +882,7 @@ typedef struct hfa384x_usb_rridresp { 
	u8 data[HFA384x_RIDDATA_MAXLEN];

} __packed hfa384x_usb_rridresp_t;



typedef hfa384x_usb_cmdresp_t hfa384x_usb_wmemresp_t;

typedef struct hfa384x_usb_statusresp hfa384x_usb_wmemresp_t;



typedef struct hfa384x_usb_rmemresp {

	u16 type;
@@ -918,7 +918,7 @@ typedef union hfa384x_usbin { 
	struct hfa384x_usb_rxfrm rxfrm;

	struct hfa384x_usb_txfrm txfrm;

	struct hfa384x_usb_infofrm infofrm;

	hfa384x_usb_cmdresp_t cmdresp;

	struct hfa384x_usb_statusresp cmdresp;

	hfa384x_usb_wridresp_t wridresp;

	hfa384x_usb_rridresp_t rridresp;

	hfa384x_usb_wmemresp_t wmemresp;

drivers/staging/wlan-ng/hfa384x_usb.c

+4 −4
Original line number Diff line number Diff line
@@ -212,7 +212,7 @@ unlocked_usbctlx_cancel_async(hfa384x_t *hw, hfa384x_usbctlx_t *ctlx); 
static void hfa384x_cb_status(hfa384x_t *hw, const hfa384x_usbctlx_t *ctlx);



static int

usbctlx_get_status(const hfa384x_usb_cmdresp_t *cmdresp,

usbctlx_get_status(const struct hfa384x_usb_statusresp *cmdresp,

		   hfa384x_cmdresult_t *result);



static void
@@ -621,7 +621,7 @@ static hfa384x_usbctlx_t *usbctlx_alloc(void) 
}



static int

usbctlx_get_status(const hfa384x_usb_cmdresp_t *cmdresp,

usbctlx_get_status(const struct hfa384x_usb_statusresp *cmdresp,

		   hfa384x_cmdresult_t *result)

{

	result->status = le16_to_cpu(cmdresp->status);
@@ -652,7 +652,7 @@ usbctlx_get_rridresult(const hfa384x_usb_rridresp_t *rridresp, 
struct usbctlx_cmd_completor {

	struct usbctlx_completor head;



	const hfa384x_usb_cmdresp_t *cmdresp;

	const struct hfa384x_usb_statusresp *cmdresp;

	hfa384x_cmdresult_t *result;

};
@@ -667,7 +667,7 @@ static inline int usbctlx_cmd_completor_fn(struct usbctlx_completor *head) 
static inline struct usbctlx_completor *init_cmd_completor(

						struct usbctlx_cmd_completor

							*completor,

						const hfa384x_usb_cmdresp_t

						const struct hfa384x_usb_statusresp

							*cmdresp,

						hfa384x_cmdresult_t *result)

{